Clients::getClientEntity() - Code Metrics - Inspection of "update for new orm access patterns" - bytic/hello - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 056d39...c33903 )

by Gabriel

created 2020-10-20 13:21 UTC

Clients::getClientEntity() A

↳ Parent: Clients

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	2
c	1
b	0
f	1
dl	0
loc	12
rs	10
ccs	0
cts	3
cp	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace ByTIC\Hello\Models\Clients;

use League\OAuth2\Server\Repositories\ClientRepositoryInterface;
use Nip\Records\Collections\Collection;
use Nip\Utility\Traits\SingletonTrait;

/**
 * Class Tokens
 * @package ByTIC\Hello\Models\Clients
 *
 * @method Client getNew()
 * @method Client findOneByIdentifier(string $clientIdentifier)
 * @method Client findOne(string $clientIdentifier)
 *
 * @method Client[]|Collection findByRedirect(string $uri)
 */
class Clients extends \Nip\Records\RecordManager implements ClientRepositoryInterface
{
    use SingletonTrait;

    /**
     * {@inheritdoc}
     */
    public function getClientEntity($clientIdentifier)
    {
        $client = $this->findOneByIdentifier($clientIdentifier);

//        if (!$client || !$client->handlesGrant($grantType)) {
//            return;
//        }
//
//        if ($mustValidateSecret && !$client->validateSecret($clientSecret)) {
//            return;
//        }
        return $client;
    }

    /** @noinspection PhpMissingParentCallCommonInspection
     * @inheritDoc
     */
    protected function generateTable()
    {
        return 'oauth_clients';
    }

    /**
     * @inheritDoc
     * @TODO add some validation logic
     */
    public function validateClient($clientIdentifier, $clientSecret, $grantType)
    {
        return true;
    }
}


1		<?php
2
3		namespace ByTIC\Hello\Models\Clients;
4
5		use League\OAuth2\Server\Repositories\ClientRepositoryInterface;
6		use Nip\Records\Collections\Collection;
7		use Nip\Utility\Traits\SingletonTrait;
8
9		/**
10		* Class Tokens
11		* @package ByTIC\Hello\Models\Clients
12		*
13		* @method Client getNew()
14		* @method Client findOneByIdentifier(string $clientIdentifier)
15		* @method Client findOne(string $clientIdentifier)
16		*
17		* @method Client[]\|Collection findByRedirect(string $uri)
18		*/
19		class Clients extends \Nip\Records\RecordManager implements ClientRepositoryInterface
20		{
21	1	use SingletonTrait;
22
23		/**
24		* {@inheritdoc}
25		*/
26		public function getClientEntity($clientIdentifier)
27		{
28		$client = $this->findOneByIdentifier($clientIdentifier);
29
30		// if (!$client \|\| !$client->handlesGrant($grantType)) {
31		// return;
32		// }
33		//
34		// if ($mustValidateSecret && !$client->validateSecret($clientSecret)) {
35		// return;
36		// }
37		return $client;
38		}
39
40		/** @noinspection PhpMissingParentCallCommonInspection
41		* @inheritDoc
42		*/
43		protected function generateTable()
44		{
45		return 'oauth_clients';
46		}
47
48		/**
49		* @inheritDoc
50		* @TODO add some validation logic
51		*/
52		public function validateClient($clientIdentifier, $clientSecret, $grantType)
53		{
54		return true;
55		}
56		}
57

bytic / hello

Push — master ( 056d39...c33903 )

Clients::getClientEntity() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like