ByTIC\Hello\Modules\AbstractModule\Controllers\Traits\LoginControllerTrait::index()

Complexity

Conditions	4
Paths	4

Size

Total Lines	26
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function index()
    {
        $usersManager = $this->getModelManager();

It seems like getModelManager() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->getView()->set('headerTitle', $usersManager->getLabel('login-title'));

        $loginForm = $this->_getUser()->getForm('login');

It seems like _getUser() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($loginForm->submited()) {
            if ($loginForm->processRequest()) {
                $this->doSuccessRedirect();

It seems like doSuccessRedirect() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        } else {
            if ($this->getRequest()->query->has('message')) {
                $loginForm->addMessage($this->getRequest()->query->get('message'), 'info');
            }
        }

        $this->forms['login'] = $loginForm;

The property forms does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->getView()->set('redirect', $this->getRedirectURL());

It seems like getRedirectURL() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->_setMeta('login');

It seems like _setMeta() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->getView()->Breadcrumbs()->addItem(
            $this->getModelManager()->getLabel('login-title'),
            $this->_getUser()->getManager()->compileURL('login')
        );
        $this->getView()->Meta()->prependTitle($this->getModelManager()->getLabel('login-title'));
    }