bytic / goutte-phantomjs-bridge

src/Clients/PhantomJs/ClientBridge.php

<?php

namespace ByTIC\GouttePhantomJs\Clients\PhantomJs;

use JonnyW\PhantomJs\Client as PhantomJsBaseClient;
use JonnyW\PhantomJs\Http\RequestInterface;
use PhantomInstaller\PhantomBinary;
use Symfony\Contracts\HttpClient\HttpClientInterface;
use Symfony\Contracts\HttpClient\ResponseInterface;
use Symfony\Contracts\HttpClient\ResponseStreamInterface;

/**
 * Class PhantomJsClientBridge
 * @package ByTIC\GouttePhantomJs\Clients\PhantomJs
 */
class ClientBridge implements HttpClientInterface
{
    protected $phantomJsClient = null;

    /** @var array Default request options */
    private $config;

    /**
     * ClientBridge constructor.
     *
     * @param array $config
     */
    public function __construct(array $config = [])
    {
        $this->configureDefaults($config);
    }

    /**
     * @inheritdoc
     */
    public function request(string $method, string $url, array $options = []): ResponseInterface
    {
        $client  = $this->getPhantomJsClient();
        $request = $this->createRequest($client, $method, $url, $options);

It seems like $client defined by $this->getPhantomJsClient() on line 38 can be null; however, ByTIC\GouttePhantomJs\Clients\PhantomJs\ClientBridge::createRequest() does not accept null, maybe add an additional type check?

        $request = $this->applyConfig($request);

        /**
         * @see \JonnyW\PhantomJs\Http\Response
         **/
        $response = $client->getMessageFactory()->createResponse();

        // Send the request
        $client->send($request, $response);

        return ResponseFormatter::format($response);
    }

    /**
     * @inheritdoc
     */
    public function requestAsync($method, $uri = '', array $options = [])

The parameter $method is not used and could be removed.

The parameter $uri is not used and could be removed.

The parameter $options is not used and could be removed.

    {
    }

    /**
     * @inheritdoc
     */
    public function send(RequestInterface $request, array $options = [])

The parameter $request is not used and could be removed.

The parameter $options is not used and could be removed.

    {
    }

    /**
     * @inheritdoc
     */
    public function sendAsync(RequestInterface $request, array $options = [])

The parameter $request is not used and could be removed.

The parameter $options is not used and could be removed.

    {
    }

    /**
     * @inheritdoc
     */
    public function stream($responses, float $timeout = null): ResponseStreamInterface
    {
    }

    /**
     * @inheritdoc
     */
    public function getConfig($option = null)
    {
        return $option === null
            ? $this->config
            : (isset($this->config[$option]) ? $this->config[$option] : null);
    }

    /**
     * Configures the default options for a client.
     *
     * @param array $config
     */
    protected function configureDefaults(array $config)
    {
        $defaults = $this->getConfigDefaults();

        $this->config = $config + $defaults;
    }

    /**
     * @return array
     */
    protected function getConfigDefaults()
    {
        return [
            'request_delay' => false
        ];
    }

    /**
     * @param $option
     * @param $value
     *
     * @return mixed
     */
    public function setConfig($option, $value)
    {
        return $this->config[$option] = $value;
    }

    /**
     * @param PhantomJsBaseClient $client
     * @param $method
     * @param string $uri
     * @param array $parameters
     *
     * @return RequestInterface
     */
    protected function createRequest($client, $method, $uri = '', array $parameters = [])
    {
        /**
         * @see \JonnyW\PhantomJs\Http\Request
         **/
        $request = $client->getMessageFactory()->createRequest($uri, $method);
        $request->addHeader(
            'User-Agent',
            'Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0'
        );

        $request->addHeader(
            'Content-Type',
            'application/x-www-form-urlencoded'
        );

        if (isset($parameters['form_params'])) {
            $request->setRequestData($parameters['form_params']);
        }

        return $request;
    }

    /**
     * @param RequestInterface $request
     *
     * @return RequestInterface
     */
    protected function applyConfig($request)
    {
        $requestDelay = $this->getConfig('request_delay');
        if ($requestDelay > 0) {
            $request->setDelay($requestDelay);
        }

        return $request;
    }


    /**
     * @return PhantomJsBaseClient|null
     */
    protected function getPhantomJsClient()
    {
        if ($this->phantomJsClient === null) {
            $this->phantomJsClient = PhantomJsBaseClient::getInstance();
            $this->phantomJsClient->getEngine()->setPath(PhantomBinary::getBin());
        }

        return $this->phantomJsClient;
    }
}