bytic / form

src/Elements/CheckboxGroup.php

<?php

/**
 * Class Nip_Form_Element_CheckboxGroup
 *
 * @method Nip_Form_Element_Checkbox[] getElements()
 */
class Nip_Form_Element_CheckboxGroup extends Nip_Form_Element_Input_Group
{
    protected $_type = 'checkboxGroup';

    /**
     * @param string $requester
     * @return null
     */
    public function getValue($requester = 'abstract')

The parameter $requester is not used and could be removed.

    {
        $elements = $this->getElements();
        $data = [];
        if ($elements) {

The expression $elements of type Nip_Form_Element_Checkbox[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($elements as $element) {
                if ($element->isChecked()) {
                    $data[] = $element->getValue();
                }
            }
        }

        return $data;

The expression return $data returns the type array|array<mixed,mixed|null> which is incompatible with the documented return type null.

    }

    /** @noinspection PhpMissingParentCallCommonInspection
     * @inheritdoc
     */
    public function setValue($value)
    {
        return $this->getDataFromRequest($value);
    }

    /** @noinspection PhpMissingParentCallCommonInspection
     * @inheritdoc
     */
    public function getDataFromRequest($request)
    {
        $elements = $this->getElements();
        if (is_array($request)) {
            foreach ($elements as $key => $element) {
                $element->setChecked(in_array($key, $request));
            }
        } else {
            foreach ($elements as $key => $element) {
                $element->setChecked(false);
            }
        }

        return $this;
    }

    /**
     * @return Nip\Form\Elements\AbstractElement
     */
    public function getNewElement()
    {
        $element = $this->getForm()->getNewElement('checkbox');
        $name = $this->getName();

Are you sure the assignment to $name is correct as $this->getName() targeting Nip\Form\Elements\AbstractElement::getName() seems to always return null.

        if (!strpos($name, '[]')) {

$name of type null is incompatible with the type string expected by parameter $haystack of strpos().

            $name = $name . '[]';
        }
        $element->setName($name);

        return $element;
    }

    /**
     * @return bool
     */
    public function isRequestArray()
    {
        return true;
    }
}