bytic / form

src/Elements/AbstractElement.php

<?php

namespace Nip\Form\Elements;

use Nip\Form\AbstractForm;
use Nip\Form\Elements\Traits\HasAttributesTrait;
use Nip\Form\Elements\Traits\HasDecoratorsTrait;
use Nip\Form\Elements\Traits\HasErrorsTrait;
use Nip\Form\Elements\Traits\HasOptionsTrait;
use Nip\Form\Elements\Traits\HasRendererTrait;
use Nip\Form\Elements\Traits\HasTypeTrait;
use Nip\Form\Elements\Traits\HasUniqueIdTrait;
use Symfony\Component\Form\AbstractType;

/**
 * Class AbstractElement
 * @package Nip\Form\Elements
 */
abstract class AbstractElement extends AbstractType implements ElementInterface
{
    use HasUniqueIdTrait;
    use HasAttributesTrait;
    use HasOptionsTrait;
    use HasDecoratorsTrait;
    use HasRendererTrait;
    use HasTypeTrait;

The trait Nip\Form\Elements\Traits\HasTypeTrait requires the property $_type which is not provided by Nip\Form\Elements\AbstractElement.

    use HasErrorsTrait;

    protected $_form;

    protected $_isRequired;
    protected $_policies;

    /**
     * AbstractElement constructor.
     * @param null $form

Are you sure the doc-type for parameter $form is correct as it would always require null to be passed?

     */
    public function __construct($form = null)
    {
        if ($form) {

$form is of type null, thus it always evaluated to false.

            $this->setForm($form);
        }
        $this->init();
    }

    public function init()
    {
    }


    /**
     * @return AbstractForm
     */
    public function getForm()
    {
        return $this->_form;
    }

    /**
     * @param AbstractForm $form
     * @return $this
     */
    public function setForm(AbstractForm $form)
    {
        $this->_form = $form;

        return $this;
    }

    /**
     * @param $data
     * @param string $source
     * @return \Nip\Form\Elements\AbstractElement
     */
    public function getData($data, $source = 'abstract')
    {
        if ($source == 'model') {
            return $this->getDataFromModel($data);
        }

        return $this->getDataFromRequest($data);
    }

    /**
     * @param $data
     * @return $this
     */
    public function getDataFromModel($data)
    {
        $this->setValue($data);

        return $this;
    }

    /**
     * @param $request
     * @return $this
     */
    public function getDataFromRequest($request)
    {
        $request = $this->sanitizeDataFromRequest($request);
        $this->setValue($request);

        return $this;
    }

    /**
     * @param $request
     * @return string
     */
    protected function sanitizeDataFromRequest($request)
    {
        return clean($request);
    }

    /**
     * @param boolean $isRequired
     * @return $this
     */
    public function setRequired($isRequired)
    {
        $this->_isRequired = (bool)$isRequired;

        return $this;
    }

    public function validate()
    {
        if ($this->isRequired() && !$this->getValue()) {
            $message = $this->getForm()->getMessageTemplate('no-' . $this->getName());

Are you sure the usage of $this->getName() targeting Nip\Form\Elements\AbstractElement::getName() seems to always return null.

            if (!$message) {
                $translateSlug = 'general.form.errors.required';
                $message = app('translator')->translate($translateSlug, ['label' => $this->getLabel()]);
                if ($message == $translateSlug) {
                    $message = $message ? $message : 'The field `' . $this->getLabel() . '` is mandatory.';
                }
            }
            $this->addError($message);
        }
    }

    /**
     * @return bool
     */
    public function isRequired()
    {
        return (bool)$this->_isRequired;
    }

    /**
     * @return bool
     */
    public function isGroup()
    {
        return false;
    }

    /**
     * @return bool
     */
    public function isRequestArray()
    {
        return false;
    }
}