Nip_Form_Renderer_Elements_Select

Complexity

Total Complexity

14

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	generateElement()	0	6	1
A	isOptionSelected()	0	13	6
B	renderOptions()	0	30	7

<?php

class Nip_Form_Renderer_Elements_Select extends \Nip\Form\Renderer\Elements\AbstractElementRenderer
{
    /**
     * @return string
     */
    public function generateElement()
    {
        $return = '<select ';
        $return .= $this->renderAttributes();
        $return .= ' >' . $this->renderOptions() . '</select>';
        return $return;
    }

    public function renderOptions($options = false)
    {
        $options = $options ? $options : $this->getElement()->getOptions();
        $return = '';

        $selectedValue = $this->getElement()->getValue();

Are you sure the assignment to $selectedValue is correct as $this->getElement()->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

        foreach ($options as $value=>$atribs) {
            if (is_string($value) && !isset($atribs['label'])) {
                $return .= '<optgroup label="' . $value . '">';
                $return .= $this->renderOptions($atribs);
                $return .= '</optgroup>';
            } else {
                $return .= '<option';

                $label = $atribs['label'];
                unset($atribs['label']);

                $atribs['value'] = $value;
                if ($this->isOptionSelected($value, $selectedValue)) {
                    $atribs['selected'] = 'selected';
                }

                foreach ($atribs as $name=>$value) {

$value is overwriting a variable from outer foreach loop.

                    $return .= ' ' . $name . '="' . $value . '"';
                }
                $return .= '>' . $label . '</option>';
            }
        }
        return $return;
    }

    /**
     * @param $value
     * @param $selectedValue
     * @return bool
     */
    protected function isOptionSelected($value, $selectedValue): bool
    {
        if (is_null($selectedValue)) {
            return false;
        }
        if ($selectedValue === 0 or $value === 0) {
            if ($value === $selectedValue) {
                return true;
            }
        } elseif ($selectedValue == $value) {
            return true;
        }
        return false;
    }
}