Nip_Form_Element_RadioGroup::setValue() - Code Metrics - Inspection of "Merge branch '0.9' into develop" - bytic/form - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8431a9...0bccd4 )

by Gabriel

created 2019-02-18 12:59 UTC

Nip_Form_Element_RadioGroup::setValue() A

↳ Parent: Nip_Form_Element_RadioGroup

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	11
ccs	0
cts	7
cp	0
rs	10
cc	3
nc	3
nop	1
crap	12

<?php

class Nip_Form_Element_RadioGroup extends Nip_Form_Element_Input_Group
namespace YourVendor;

class YourClass { }
{
    protected $_type = 'radioGroup';

    /**
     * @return Nip_Form_Element_Abstract
     */
    public function getNewElement()
    {
        $element = $this->getForm()->getNewElement('radio');
        $element->setName($this->getName());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

        return $element;
    }

    /**
     * @param $value
     * @return $this
     */
    public function setValue($value)
    {
        $elements = $this->getElements();
        foreach ($elements as $element) {
            if ($element->getValue() == $value) {
                $element->setChecked(true);
                break;
            }
        }

        return parent::setValue($value);
    }

    /**
     * @param $boolean
     * @return Nip_Form_Element_RadioGroup
     */
    public function autoSelectFirst($boolean = true)
    {
        return $this->setOption('autoSelectFirst', $boolean === true);
    }

    /**
     * @return bool
     */
    public function isAutoSelectFirst()
    {
        if ($this->hasOption('autoSelectFirst') && $this->getOption('autoSelectFirst') == false) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            return false;
        }

        return true;
    }
}


1		<?php
2
3		class Nip_Form_Element_RadioGroup extends Nip_Form_Element_Input_Group
		0 ignored issues – show Coding Style Compatibility introduced 2018-08-16 13:52 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5		protected $_type = 'radioGroup';
6
7		/**
8		* @return Nip_Form_Element_Abstract
9		*/
10	3	public function getNewElement()
11		{
12	3	$element = $this->getForm()->getNewElement('radio');
13	3	$element->setName($this->getName());
		0 ignored issues – show Bug introduced 2019-02-18 13:03 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->getName()` targeting `Nip\Form\Elements\AbstractElement::getName()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
14
15	3	return $element;
16		}
17
18		/**
19		* @param $value
20		* @return $this
21		*/
22		public function setValue($value)
23		{
24		$elements = $this->getElements();
25		foreach ($elements as $element) {
26		if ($element->getValue() == $value) {
27		$element->setChecked(true);
28		break;
29		}
30		}
31
32		return parent::setValue($value);
33		}
34
35		/**
36		* @param $boolean
37		* @return Nip_Form_Element_RadioGroup
38		*/
39	2	public function autoSelectFirst($boolean = true)
40		{
41	2	return $this->setOption('autoSelectFirst', $boolean === true);
42		}
43
44		/**
45		* @return bool
46		*/
47	5	public function isAutoSelectFirst()
48		{
49	5	if ($this->hasOption('autoSelectFirst') && $this->getOption('autoSelectFirst') == false) {
		0 ignored issues – show Bug introduced 2019-02-18 13:03 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->getOption('autoSelectFirst')` targeting `Nip\Form\Elements\AbstractElement::getOption()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
50	1	return false;
51		}
52
53	4	return true;
54		}
55		}
56

bytic / form

Push — master ( 8431a9...0bccd4 )

Nip_Form_Element_RadioGroup::setValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like