Nip_Form_Element_Checkbox::getDataFromModel() - Code Metrics - Inspection of "Merge branch '0.9' into develop" - bytic/form - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8431a9...0bccd4 )

by Gabriel

created 2019-02-18 12:59 UTC

Nip_Form_Element_Checkbox::getDataFromModel() A

↳ Parent: Nip_Form_Element_Checkbox

Complexity

Conditions	3
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	4
c	1
b	0
f	0
dl	0
loc	7
ccs	0
cts	5
cp	0
rs	10
cc	3
nc	2
nop	1
crap	12

<?php

class Nip_Form_Element_Checkbox extends Nip_Form_Element_Input_Abstract
namespace YourVendor;

class YourClass { }
{
    protected $_type = 'checkbox';

    public function init()
    {
        parent::init();
        $this->setAttrib('type', 'checkbox');
    }

    /**
     * @param $request
     * @return $this
     */
    public function getDataFromRequest($request)
    {
        $this->setChecked($request != null);
        return parent::getDataFromRequest($request);
    }

    /**
     * @param boolean $checked
     * @return $this
     */
    public function setChecked($checked)
    {
        if ($checked === true) {
            $this->setAttrib('checked', 'checked');
        } else {
            $this->delAttrib('checked');
        }
        return $this;
    }

    /**
     * @param $data
     * @return $this
     */
    public function getDataFromModel($value)
    {
        $inputValue = $this->getValue();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        if ($inputValue == null && $value) {
            $this->setChecked(true);
        }
        return parent::getDataFromModel($value);
    }

    /**
     * @return bool
     */
    public function isChecked()
    {
        return $this->getAttrib('checked') == 'checked';
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }
}


1			<?php
2
3			class Nip_Form_Element_Checkbox extends Nip_Form_Element_Input_Abstract
			0 ignored issues – show Coding Style Compatibility introduced 2018-08-16 13:52 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			protected $_type = 'checkbox';
6
7			public function init()
8			{
9			parent::init();
10			$this->setAttrib('type', 'checkbox');
11			}
12
13			/**
14			* @param $request
15			* @return $this
16			*/
17			public function getDataFromRequest($request)
18			{
19			$this->setChecked($request != null);
20			return parent::getDataFromRequest($request);
21			}
22
23			/**
24			* @param boolean $checked
25			* @return $this
26			*/
27			public function setChecked($checked)
28			{
29			if ($checked === true) {
30			$this->setAttrib('checked', 'checked');
31			} else {
32			$this->delAttrib('checked');
33			}
34			return $this;
35			}
36
37			/**
38			* @param $data
39			* @return $this
40			*/
41			public function getDataFromModel($value)
42			{
43			$inputValue = $this->getValue();
			0 ignored issues – show Bug introduced 2019-02-18 13:03 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$inputValue` is correct as `$this->getValue()` targeting `Nip\Form\Elements\AbstractElement::getValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
44			if ($inputValue == null && $value) {
45			$this->setChecked(true);
46			}
47			return parent::getDataFromModel($value);
48			}
49
50			/**
51			* @return bool
52			*/
53			public function isChecked()
54			{
55			return $this->getAttrib('checked') == 'checked';
			0 ignored issues – show Bug introduced 2019-02-18 13:03 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->getAttrib('checked')` targeting `Nip\Form\Elements\AbstractElement::getAttrib()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
56			}
57			}
58

bytic / form

Push — master ( 8431a9...0bccd4 )

Nip_Form_Element_Checkbox::getDataFromModel() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like