Nip_Form_Renderer_Elements_Select

Complexity

Total Complexity

12

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	generateElement()	0	6	1
A	getElementAttribs()	0	4	1
B	renderOptions()	0	32	10

<?php
class Nip_Form_Renderer_Elements_Select extends Nip_Form_Renderer_Elements_Abstract

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function generateElement()
    {
        $return = '<select ';
        $return .= $this->renderAttributes();
        $return .= ' >' . $this->renderOptions() . '</select>';
        return $return;
    }

    public function renderOptions($options = false)
    {
        $options = $options ? $options : $this->getElement()->getOptions();

The method getOptions() does not exist on Nip_Form_Element_Abstract. Did you maybe mean getOption()?

        $return = '';
        foreach ($options as $value=>$atribs) {
            if (is_string($value) && !isset($atribs['label'])) {
                $return .= '<optgroup label="' . $value . '">';
                $return .= $this->renderOptions($atribs);
                $return .= '</optgroup>';
            } else {
                $return .= '<option';

                $label = $atribs['label'];
                unset($atribs['label']);

                $atribs['value'] = $value;
                $selectedValue = $this->getElement()->getValue();

Are you sure the assignment to $selectedValue is correct as $this->getElement()->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

                if ($selectedValue === 0 or $value === 0) {

Using logical operators such as or instead of || is generally not recommended.

                    if ($value === $selectedValue) {
                        $atribs['selected'] = 'selected';
                    }
                } elseif ($this->getElement()->getValue() == $value) {

Are you sure the usage of $this->getElement()->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

                    $atribs['selected'] = 'selected';
                }
                
                foreach ($atribs as $name=>$value) {

$value is overwriting a variable from outer foreach loop.

                    $return .= ' ' . $name . '="' . $value . '"';
                }
                $return .= '>' . $label . '</option>';
            }
        }
        return $return;
    }

    public function getElementAttribs()
    {
        $attribs = parent::getElementAttribs();
        return $attribs;
    }
}