Nip_Form_Renderer_Button_Abstract

Complexity

Total Complexity

13

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	setRenderer()	0	5	1
A	render()	0	6	1
A	renderAttributes()	0	19	5
A	renderItem()	0	5	1
A	getRenderer()	0	3	1
A	setItem()	0	5	1
A	generateItem()	0	3	1
A	getItem()	0	3	1
A	getItemAttribs()	0	3	1

<?php

use Nip\Form\Renderer\AbstractRenderer;

/**
 * Class Nip_Form_Renderer_Button_Abstract
 */
abstract class Nip_Form_Renderer_Button_Abstract

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected $_renderer;

    protected $_button;

    /**
     * @param AbstractRenderer $renderer
     * @return $this
     */
    public function setRenderer(AbstractRenderer $renderer)
    {
        $this->_renderer = $renderer;

        return $this;
    }

    /**
     * @return AbstractRenderer
     */
    public function getRenderer()
    {
        return $this->_renderer;
    }

    /**
     * @param Nip_Form_Button_Abstract $item
     * @return $this
     */
    public function setItem(Nip_Form_Button_Abstract $item)
    {
        $this->_item = $item;

The property _item does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;
    }

    /**
     * @return Nip_Form_Button_Abstract
     */
    public function getItem()
    {
        return $this->_item;
    }


    public function render()
    {
        $return = '';
        $return .= $this->renderItem();

Are you sure the usage of $this->renderItem() targeting Nip_Form_Renderer_Button_Abstract::renderItem() seems to always return null.

        return $return;
    }

    public function renderItem()
    {
        $return = $this->generateItem();

Are you sure the assignment to $return is correct as $this->generateItem() targeting Nip_Form_Renderer_Button_Abstract::generateItem() seems to always return null.

        return $return;
    }

    public function generateItem()
    {
        return;
    }

    public function renderAttributes($overrides = [])
    {
        $attribs = $this->getItem()->getAttribs();
        if (!isset($attribs['title'])) {
            $attribs['title'] = $this->getItem()->getLabel();
        }
        $itemAttribs = $this->getItemAttribs();
        $return = '';
        foreach ($attribs as $name => $value) {
            if (in_array($name, $itemAttribs)) {
                if (in_array($name, array_keys($overrides))) {
                    $value = $overrides[$name];
                }

                $return .= ' '.$name.'="'.$value.'"';
            }
        }

        return $return;
    }

    /**
     * @return array
     */
    public function getItemAttribs()
    {
        return ['id', 'name', 'style', 'class', 'title', 'read_only', 'disabled'];
    }
}