Nip_Form_Element_MultiElement

Complexity

Total Complexity

5

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Test Coverage

Coverage

23.08%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getElements()	0	4	1
A	addElement()	0	5	1
A	getElement()	0	6	2
A	hasElement()	0	3	1

<?php

class Nip_Form_Element_MultiElement extends Nip_Form_Element_Abstract

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

The class Nip_Form_Element_Abstract has been deprecated: Use Nip\Form\Elements\AbstractElement

{
    protected $_type = 'multiElement';

    /**
     * @var Nip_Form_Element_Abstract[]
     */
    protected $elements = [];

    /**
     * @param Nip_Form_Element_Abstract $element
     * @return $this
     */
    public function addElement(Nip_Form_Element_Abstract $element)
    {
        $key = $element->getName();

Are you sure the assignment to $key is correct as $element->getName() targeting Nip\Form\Elements\AbstractElement::getName() seems to always return null.

        $this->elements[$key] = $element;
        return $this;
    }

    /**
     * @return Nip_Form_Element_Abstract[]
     */
    public function getElements()
    {
        reset($this->elements);
        return $this->elements;
    }

    /**
     * @param $name
     * @return Nip_Form_Element_Abstract
     * @throws \Nip\Logger\Exception
     */
    public function getElement($name)
    {
        if ($this->hasElement($name)) {
            return $this->elements[$name];
        }
        throw new \Nip\Logger\Exception("Invalid child element");

The type Nip\Logger\Exception was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    /**
     * @param $name
     * @return bool
     */
    public function hasElement($name)
    {
        return isset($this->elements[$name]);
    }
}