Nip_Form_Element_Input_Group

Complexity

Total Complexity

11

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Test Coverage

Coverage

38.24%

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	isGroup()	0	3	1
A	getElement()	0	3	1
A	addOptionsArray()	0	17	3
A	getValues()	0	3	1
A	getNewElement()	0	3	1
A	addOption()	0	8	1
A	isRequestArray()	0	3	1
A	addElement()	0	6	1
A	getElements()	0	3	1

<?php

/**
 * Class Nip_Form_Element_Input_Group
 */
abstract class Nip_Form_Element_Input_Group extends Nip_Form_Element_Abstract

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

The class Nip_Form_Element_Abstract has been deprecated: Use Nip\Form\Elements\AbstractElement

{
    protected $_type = 'input_group';
    protected $_elements = [];
    protected $_values = [];

    public function isGroup()
    {
        return true;
    }

    public function isRequestArray()
    {
        return false;
    }

    public function addOptionsArray($options, $valueKey, $labelKey)
    {
        foreach ($options as $key => $option) {
            $option = (object) $option;


            $oValue    = $option->{$valueKey};
            $oLabel = $option->{$labelKey};
            $oDisabled = $option->disabled;

            if ($oDisabled) {
                $atribs['disabled'] = 'disabled';
            }
            $this->addOption($oValue, $oLabel, $atribs);

The variable $atribs does not seem to be defined for all execution paths leading up to this point.

        }

        return $this;
    }

    /**
     * @return Nip_Form_Element_Input_Group
     */
    public function addOption($value, $label, $attribs = [])
    {
        $element = $this->getNewElement();
        $element->setValue($value);
        $element->setLabel($label);
        $element->addAttribs($attribs);

        return $this->addElement($element);

$element of type Nip_Form_Element_Abstract is incompatible with the type Nip_Form_Element_Input_Abstract expected by parameter $element of Nip_Form_Element_Input_Group::addElement().

    }

    /**
     * @return Nip_Form_Element_Abstract
     */
    public function getNewElement()
    {
        trigger_error('No new element funtion defined for this group', E_USER_ERROR);
    }

    public function addElement(Nip_Form_Element_Input_Abstract $element)
    {
        $key = $element->getValue();

Are you sure the assignment to $key is correct as $element->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

        $this->_elements[$key] = $element;
        $this->_values[] = $key;
        return $this;
    }

    public function getElement($key)
    {
        return $this->_elements[$key];
    }

    public function getElements()
    {
        return $this->_elements;
    }

    public function getValues()
    {
        return $this->_values;
    }
}