Nip_Form_Element_Timeselect

Complexity

Total Complexity

29

Size/Duplication

Total Lines	154
Duplicated Lines	30.52 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

59.49%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getValue()	0	8	3
A	updateNameSelects()	0	6	1
A	getData()	0	14	5
A	setName()	0	6	1
A	init()	0	5	1
A	validate()	0	13	5
B	initSelects()	0	37	7
A	getDataFromRequest()	0	13	4
A	getUnix()	0	10	2

<?php

class Nip_Form_Element_Timeselect extends Nip_Form_Element_MultiElement

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected $_type = 'timeselect';

    public function init()
    {
        parent::init();

        $this->initSelects();
    }

    public function initSelects()
    {
        if (! isset($this->elements['hours'])) {
            $hoursElement = $this->getForm()->getNewSelectElement();

            $hoursElement->addOption('-', 'HH');

The method addOption() does not exist on Nip_Form_Element_Abstract. It seems like you code against a sub-type of Nip_Form_Element_Abstract such as Nip_Form_Element_Select or Nip_Form_Element_Input_Group.

            for ($i = 0; $i <= 24; $i++) {
                $hoursElement->addOption($i, $i . 'h');
            }
            $hoursElement->setValue('-');

            $this->elements['hours'] = $hoursElement;
        }


        if (! isset($this->elements['minutes'])) {
            $minutesElement = $this->getForm()->getNewSelectElement();

            $minutesElement->addOption('-', 'MM');
            for ($i = 0; $i <= 59; $i++) {
                $minutesElement->addOption($i, $i . 'm');
            }
            $minutesElement->setValue('-');

            $this->elements['minutes'] = $minutesElement;
        }

        if (! isset($this->elements['seconds'])) {
            $secondsElement = $this->getForm()->getNewSelectElement();

            $secondsElement->addOption('-', 'SS');
            for ($i = 0; $i <= 59; $i++) {
                $secondsElement->addOption($i, $i . 's');
            }
            $secondsElement->setValue('-');

            $this->elements['seconds'] = $secondsElement;
        }
    }

    /**
     * @inheritdoc
     */
    public function setName($name)
    {
        $return = parent::setName($name);
        $this->updateNameSelects();

        return $return;
    }

    public function updateNameSelects()
    {
        $inputName = $this->getName();

Are you sure the assignment to $inputName is correct as $this->getName() targeting Nip\Form\Elements\AbstractElement::getName() seems to always return null.

        $this->elements['hours']->setName($inputName . '[hours]');
        $this->elements['minutes']->setName($inputName . '[minutes]');
        $this->elements['seconds']->setName($inputName . '[seconds]');
    }

    /**
     * @inheritdoc
     */
    public function getData($data, $source = 'abstract')
    {
        if ($source == 'model') {
            $dateUnix = strtotime($data);
            if ($dateUnix && $dateUnix !== false && $dateUnix > -62169989992) {
                $this->elements['hours']->setValue(date('H', $dateUnix));
                $this->elements['minutes']->setValue(date('i', $dateUnix));
                $this->elements['seconds']->setValue(date('s', $dateUnix));
            }

            return $this;
        }

        return parent::getData($data, $source);
    }

    /** @noinspection PhpMissingParentCallCommonInspection
     * @inheritdoc
     */
    public function getDataFromRequest($request)
    {
        if (is_array($request)) {
            $elements = $this->getElements();
            foreach ($elements as $key => $element) {
                if (isset($request[$key])) {
                    $value = $request[$key];
                    $element->setValue($value);
                }
            }
        }

        return $this;
    }

    public function validate()
    {
        parent::validate();
        if (! $this->isError()) {
            $value = $this->getValue();
            if ($value) {
                $expectedValue = str_pad(intval($this->elements['hours']->getValue()), 2, "0", STR_PAD_LEFT);

Are you sure the usage of $this->elements['hours']->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

                $expectedValue .= ':' . str_pad(intval($this->elements['minutes']->getValue()), 2, "0", STR_PAD_LEFT);

Are you sure the usage of $this->elements['minutes']->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

                $expectedValue .= ':' . str_pad(intval($this->elements['seconds']->getValue()), 2, "0", STR_PAD_LEFT);

Are you sure the usage of $this->elements['seconds']->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

                if ($expectedValue != $value) {
                    $message = $this->getForm()->getMessageTemplate('bad-' . $this->getName());

Are you sure the usage of $this->getName() targeting Nip\Form\Elements\AbstractElement::getName() seems to always return null.

                    $message = $message ? $message : 'I couldn\'t parse the ' . strtolower($this->getLabel()) . ' you entered';
                    $this->addError($message);
                }
            }
        }
    }

    /** @noinspection PhpMissingDocCommentInspection
     * @inheritdoc
     */
    public function getValue($requester = 'abstract')
    {
        $unixTime = $this->getUnix();
        $format   = $requester == 'model' ? 'H:i:s' : 'H:i:s';

        $value = ($unixTime) ? date($format, $unixTime) : null;

        return $value;
    }


    /** @noinspection PhpMissingDocCommentInspection
     * @inheritdoc
     */
    public function getUnix($format = false)

The parameter $format is not used and could be removed.

    {
        $hour    = intval($this->elements['hours']->getValue());

Are you sure the usage of $this->elements['hours']->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

        $minutes = intval($this->elements['minutes']->getValue());

Are you sure the usage of $this->elements['minutes']->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

        $seconds = intval($this->elements['seconds']->getValue());

Are you sure the usage of $this->elements['seconds']->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

        if ($hour + $minutes + $seconds > 0) {
            return mktime($hour, $minutes, $seconds);
        }

        return false;
    }
}