Nip_Form_Element_Hash

Complexity

Total Complexity

11

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getSalt()	0	3	1
A	reset()	0	6	1
A	validate()	0	6	3
A	init()	0	4	1
A	initSession()	0	8	2
A	_generateHash()	0	8	1
A	getSessionName()	0	3	1
A	getSessionValue()	0	5	1

<?php

class Nip_Form_Element_Hash extends Nip_Form_Element_Hidden

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected $_ID;

    public function init()
    {
        parent::init();
        $this->initSession();
    }

    public function initSession()
    {
        $name = $this->getSessionName();
        if (!$_SESSION[$name]) {
            $this->reset();
        }

        $this->setValue($this->getSessionValue());
    }

    public function reset()
    {
        $name = $this->getSessionName();
        $hash = $this->_generateHash();
        $_SESSION[$name] = $hash;
        $this->setValue($hash);
    }

    public function validate()
    {
        if (!$this->getValue()) {

Are you sure the usage of $this->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

            $this->addError('Request received without security hash');
        } elseif ($this->getValue() != $this->getSessionValue()) {

Are you sure the usage of $this->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

            $this->addError('Form security hash different from server');
        }
    }

    public function getSessionName()
    {
        return $this->getForm()->getName().'_'.$this->getSalt();
    }

    public function getSessionValue()
    {
        $name = $this->getSessionName();

        return $_SESSION[$name];
    }

    public function getSalt()
    {
        return sha1(__CLASS__);
    }

    protected function _generateHash()
    {
        return md5(
            mt_rand(1, 1000000)
            .$this->getSalt()
            .$this->getName()

Are you sure the usage of $this->getName() targeting Nip\Form\Elements\AbstractElement::getName() seems to always return null.

            .session_id()
            .mt_rand(1, 1000000)
        );
    }
}