Nip_Form_DisplayGroup

Complexity

Total Complexity

9

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

34.78%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getForm()	0	4	1
A	setForm()	0	6	1
A	addElement()	0	6	1
A	setLegend()	0	4	1
A	getLegend()	0	4	1
A	render()	0	4	1
A	getRenderer()	0	8	2
A	getNewRenderer()	0	9	1

<?php

use Nip\Collections\Collection;
use Nip\Form\AbstractForm;
use Nip\Form\Elements\AbstractElement;

/**
 * Class Nip_Form_DisplayGroup
 */
class Nip_Form_DisplayGroup extends Collection

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    use \Nip\Form\Utility\HasAttributesTrait;

    /**
     * @var Nip_Form
     */
    protected $_form;

    protected $renderer;

    /**
     * @return Nip_Form|null
     */
    public function getForm()
    {
        return $this->_form;
    }

    /**
     * @param  AbstractForm $form
     * @return Nip_Form_DisplayGroup
     */
    public function setForm(AbstractForm $form)
    {
        $this->_form = $form;

$form is of type object<Nip\Form\AbstractForm>, but the property $_form was declared to be of type object<Nip_Form>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        return $this;
    }

    /**
     * @param AbstractElement $element
     * @return $this
     */
    public function addElement(AbstractElement $element)
    {
        $this[$element->getUniqueId()] = $element;

        return $this;
    }

    /**
     * @param string $legend
     * @return Nip_Form_DisplayGroup
     */
    public function setLegend($legend)
    {
        return $this->setAttrib('legend', (string)$legend);
    }

    /**
     * @return mixed|null
     */
    public function getLegend()
    {
        return $this->getAttrib('legend');
    }

    /**
     * @return mixed
     */
    public function render()
    {
        return $this->getRenderer()->render();
    }

    /**
     * @return Nip_Form_Renderer_DisplayGroup
     */
    public function getRenderer()
    {
        if (!$this->renderer) {
            $this->renderer = $this->getNewRenderer();
        }

        return $this->renderer;
    }

    /**
     * @param string $type
     * @return Nip_Form_Renderer_DisplayGroup
     */
    public function getNewRenderer($type = 'basic')

The parameter $type is not used and could be removed.

    {
        $name = 'Nip_Form_Renderer_DisplayGroup';
        /** @var Nip_Form_Renderer_DisplayGroup $renderer */
        $renderer = new $name();
        $renderer->setGroup($this);

        return $renderer;
    }
}