Nip_Form_Renderer_Button_Abstract

Complexity

Total Complexity

8

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setRenderer()	0	5	1
A	render()	0	6	1
A	renderItem()	0	5	1
A	getRenderer()	0	3	1
A	setItem()	0	5	1
A	generateItem()	0	3	1
A	getItem()	0	3	1
A	getElement()	0	3	1

<?php

use Nip\Form\Buttons\AbstractButton;
use Nip\Form\Renderer\AbstractRenderer;
use Nip\Form\Renderer\Traits\HasAttribsTrait;

/**
 * Class Nip_Form_Renderer_Button_Abstract
 */
abstract class Nip_Form_Renderer_Button_Abstract
{
    use HasAttribsTrait;

    protected $_renderer;
    protected $_button;

    /**
     * @return AbstractRenderer
     */
    public function getRenderer()
    {
        return $this->_renderer;
    }

    /**
     * @param AbstractRenderer $renderer
     * @return $this
     */
    public function setRenderer(AbstractRenderer $renderer)
    {
        $this->_renderer = $renderer;

        return $this;
    }

    /**
     * @param AbstractButton $item
     * @return $this
     */
    public function setItem(AbstractButton $item)
    {
        $this->_item = $item;

The property _item does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;
    }

    /**
     * @return AbstractButton
     */
    public function getElement()
    {
        return $this->getItem();
    }

    /**
     * @return AbstractButton
     */
    public function getItem()
    {
        return $this->_item;
    }

    public function render()
    {
        $return = '';
        $return .= $this->renderItem();

Are you sure the usage of $this->renderItem() targeting Nip_Form_Renderer_Button_Abstract::renderItem() seems to always return null.

        return $return;
    }

    public function renderItem()
    {
        $return = $this->generateItem();

Are you sure the assignment to $return is correct as $this->generateItem() targeting Nip_Form_Renderer_Button_Abstract::generateItem() seems to always return null.

        return $return;
    }

    public function generateItem()
    {
        return;
    }
}