bytic /
form
| Conditions | 12 |
| Paths | 9 |
| Total Lines | 25 |
| Code Lines | 18 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 156 |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 14 | protected function getDataFromRequest($request) |
||
| 15 | { |
||
| 16 | $elements = $this->getElements(); |
||
|
Bug
introduced
by
|
|||
| 17 | if (is_array($elements)) { |
||
| 18 | foreach ($elements as $name => $element) { |
||
| 19 | if ($element->isGroup() && $element->isRequestArray()) { |
||
| 20 | $name = str_replace('[]', '', $name); |
||
| 21 | |||
| 22 | if (isset($request[$name])) { |
||
| 23 | $data = is_array($request[$name]) ? $request[$name] : [$request[$name]]; |
||
| 24 | $element->getData($data, 'request'); |
||
| 25 | } |
||
| 26 | } else { |
||
| 27 | $value = isset($request[$name]) ? $request[$name] : null; |
||
| 28 | if (strpos($name, '[') && strpos($name, ']')) { |
||
| 29 | $arrayPrimary = substr($name, 0, strpos($name, '[')); |
||
| 30 | $arrayKeys = str_replace($arrayPrimary, '', $name); |
||
| 31 | |||
| 32 | preg_match_all('/\[([^\]]*)\]/', $arrayKeys, $arr_matches, PREG_PATTERN_ORDER); |
||
| 33 | $value = $request[$arrayPrimary]; |
||
| 34 | foreach ($arr_matches[1] as $dimension) { |
||
| 35 | $value = isset($value[$dimension]) ? $value[$dimension] : null; |
||
| 36 | } |
||
| 37 | } |
||
| 38 | $element->getData($value, 'request'); |
||
| 39 | } |
||
| 89 |
Loading history...