Nip\Form\Traits\HasErrorsTrait

Complexity

Total Complexity

10

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getElementsErrors()	0	9	2
A	getErrors()	0	5	1
A	addError()	0	5	1
A	generateElementsErrors()	0	9	4
A	getErrorsByField()	0	7	2

<?php

namespace Nip\Form\Traits;

/**
 * Trait HasErorsTrait
 * @package Nip\Form\Traits
 */
trait HasErrorsTrait
{
    protected $errorsByField = null;

    /**
     * @return array
     */
    public function getErrors()
    {
        $errors = array_merge((array)$this->getMessagesType('error'), $this->getElementsErrors());

It seems like getMessagesType() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $errors;
    }

    /**
     * @return array
     */
    public function getElementsErrors()
    {
        $elementsErrors = $this->getErrorsByField();
        $errors = [];
        foreach ($elementsErrors as $name => $elementErrors) {
            $errors = array_merge($errors, $elementErrors);
        }

        return $errors;
    }

    /**
     * @param $message
     * @return $this
     */
    public function addError($message)
    {
        $this->addMessage($message, 'error');

It seems like addMessage() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this;
    }

    /**
     * @return array
     */
    public function getErrorsByField(): array
    {
        if ($this->errorsByField === null) {
            $this->generateElementsErrors();
        }

        return $this->errorsByField;
    }

    protected function generateElementsErrors()
    {
        $elements = $this->getElements();

The method getElements() does not exist on Nip\Form\Traits\HasErrorsTrait. Did you maybe mean getElementsErrors()?

        $this->errorsByField = [];
        if (is_array($elements)) {
            foreach ($elements as $name => $element) {
                $elementErrors = $element->getErrors();
                if (count($elementErrors)) {
                    $this->errorsByField[$name] = $elementErrors;
                }
            }
        }
    }
}