Nip\Form\Renderer\Traits\HasAttribsTrait

Complexity

Total Complexity

9

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Test Coverage

Coverage

96%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getAllowedAttributes()	0	3	1
A	renderAttributes()	0	24	4
A	canRenderAttribute()	0	10	4

<?php

namespace Nip\Form\Renderer\Traits;

use Nip\Utility\Str;

/**
 * Trait HasAttribsTrait
 * @package Nip\Form\Renderer\Traits
 */
trait HasAttribsTrait
{
    /**
     * @param array $overrides
     * @return string
     */
    public function renderAttributes($overrides = [])
    {
        $attribs = $this->getElement()->getAttribs();

It seems like getElement() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (!isset($attribs['title'])) {
            $attribs['title'] = $this->getElement()->getLabel();
        }
        $allowedAttribs = $this->getAllowedAttributes();
        $attribs = array_filter(
            $attribs,
            function ($key) use ($allowedAttribs) {
                return $this->canRenderAttribute($key, $allowedAttribs);
            },
            ARRAY_FILTER_USE_KEY
        );
        $return = '';
        foreach ($attribs as $name => $value) {
            if (in_array($name, array_keys($overrides))) {
                $value = $overrides[$name];
            }

            $return .= ' ' . $name . '="' . $value . '"';
        }

        return $return;
    }

    /**
     * @return array
     */
    public function getAllowedAttributes()
    {
        return ['id', 'name', 'style', 'class', 'title', 'read_only', 'disabled'];
    }

    /**
     * @param $name
     * @param null $allowed

Are you sure the doc-type for parameter $allowed is correct as it would always require null to be passed?

     * @return bool
     */
    protected function canRenderAttribute($name, $allowed = null)
    {
        $allowed = $allowed ?: $this->getAllowedAttributes();

$allowed is of type null, thus it always evaluated to false.

        if (in_array($name, $allowed)) {
            return true;
        }
        if (Str::startsWith($name, 'data-')) {
            return true;
        }
        return false;
    }
}