FilesystemManager::createLocalDriver() - Code Metrics - Inspection of "Merge branch '0.9' into develop" - bytic/filesystem - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( dee4cd...d18a68 )

by Gabriel

created 2020-04-19 17:03 UTC

FilesystemManager::createLocalDriver() A

↳ Parent: FilesystemManager

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	20
ccs	11
cts	11
cp	1
rs	9.6
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php

namespace Nip\Filesystem;

use InvalidArgumentException;
use League\Flysystem\Adapter\Local as LocalAdapter;
use League\Flysystem\AdapterInterface;
use League\Flysystem\FilesystemInterface;

/**
 * Class FilesystemManager
 * @package Nip\Filesystem
 */
class FilesystemManager
{
    use FilesystemManager\HasCloudDriverTrait;
    use FilesystemManager\HasDisksTrait;
    use FilesystemManager\HasCacheStoreTrait;

    /**
     * The application instance.
     *
     * @var \Nip\Application
     */
    protected $app;

    /**
     * The registered custom driver creators.
     *
     * @var array
     */
    protected $customCreators = [];


    /**
     * Create a new filesystem manager instance.
     *
     * @param  \Nip\Application $app
     */
    public function __construct($app = null)
    {
        if ($app) {
            $this->app = $app;
        }
    }

    /**
     * Resolve the given disk.
     *
     * @param  string $name
     * @return FileDisk
     *
     * @throws \InvalidArgumentException
     */
    protected function resolve($name)
    {
        $config = $this->getConfig($name);
        if (empty($config)) {
            throw new InvalidArgumentException("No configuration found for Disk [{$name}].");
        }

        if (isset($this->customCreators[$config['driver']])) {
            return $this->callCustomCreator($config);
        }
        $driverMethod = 'create'.ucfirst($config['driver']).'Driver';
        if (method_exists($this, $driverMethod)) {
            return $this->{$driverMethod}($config);
        } else {
            throw new InvalidArgumentException("Driver [{$config['driver']}] is not supported.");
        }
    }

    /**
     * Get the filesystem connection configuration.
     *
     * @param  string $name
     * @return array
     */
    protected function getConfig($name)
    {
        if (!function_exists('config')) {
            return null;
        }
        $config = config();
        $configName = "filesystems.disks.{$name}";
        if (!$config->has($configName)) {
            return null;
        }

        return $config->get($configName)->toArray();
    }

    /**
     * Call a custom driver creator.
     *
     * @param  array $config
     * @return FileDisk
     */
    protected function callCustomCreator(array $config)
    {
        $driver = $this->customCreators[$config['driver']]($this->app, $config);
        if ($driver instanceof FilesystemInterface) {
            return $this->adapt($driver);
        }

        return $driver;
    }

    /**
     * Adapt the filesystem implementation.
     *
     * @param  \League\Flysystem\FilesystemInterface $filesystem
     * @return \League\Flysystem\FilesystemInterface|FileDisk
     */
    protected function adapt(FilesystemInterface $filesystem)
    {
        return $filesystem;
//        return new FlysystemAdapter($filesystem);
    }

    /**
     * Create an instance of the local driver.
     *
     * @param  array $config
     * @return \League\Flysystem\FilesystemInterface
     */
    public function createLocalDriver($config)
    {
        $permissions = isset($config['permissions']) ? $config['permissions'] : [];
        $links = [];
//        $links = Arr::get($config, 'links') === 'skip'
//            ? LocalAdapter::SKIP_LINKS
//            : LocalAdapter::DISALLOW_LINKS;

        return $this->adapt(
            $this->createDisk(
                new LocalAdapter(
                    $config['root'],
                    LOCK_EX,
                    $links,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    $permissions
                ),
                $config
            )
        );
    }

    /**
     * Create a Flysystem instance with the given adapter.
     *
     * @param  \League\Flysystem\AdapterInterface $adapter
     * @param  array $config
     * @return FileDisk
     */
    protected function createDisk(AdapterInterface $adapter, $config)
    {
//        $config = Arr::only($config, ['visibility', 'disable_asserts', 'url']);

        $this->checkForCacheNeeded($adapter, $config);

        return new FileDisk($adapter, count($config) > 0 ? $config : null);
    }


    /**
     * Set the given disk instance.
     *
     * @param  string $name
     * @param  FileDisk $disk
     * @return void
     */
    public function set($name, $disk)
    {
        $this->disks[$name] = $disk;
    }

    /**
     * Get the default cloud driver name.
     *
     * @return string
     */
    public function getDefaultCloudDriver()
    {
        return config('filesystems.cloud');
    }
}


1		<?php
2
3		namespace Nip\Filesystem;
4
5		use InvalidArgumentException;
6		use League\Flysystem\Adapter\Local as LocalAdapter;
7		use League\Flysystem\AdapterInterface;
8		use League\Flysystem\FilesystemInterface;
9
10		/**
11		* Class FilesystemManager
12		* @package Nip\Filesystem
13		*/
14		class FilesystemManager
15		{
16		use FilesystemManager\HasCloudDriverTrait;
17		use FilesystemManager\HasDisksTrait;
18		use FilesystemManager\HasCacheStoreTrait;
19
20		/**
21		* The application instance.
22		*
23		* @var \Nip\Application
24		*/
25		protected $app;
26
27		/**
28		* The registered custom driver creators.
29		*
30		* @var array
31		*/
32		protected $customCreators = [];
33
34
35		/**
36		* Create a new filesystem manager instance.
37		*
38		* @param \Nip\Application $app
39		*/
40	2	public function __construct($app = null)
41		{
42	2	if ($app) {
43		$this->app = $app;
44		}
45	2	}
46
47		/**
48		* Resolve the given disk.
49		*
50		* @param string $name
51		* @return FileDisk
52		*
53		* @throws \InvalidArgumentException
54		*/
55		protected function resolve($name)
56		{
57		$config = $this->getConfig($name);
58		if (empty($config)) {
59		throw new InvalidArgumentException("No configuration found for Disk [{$name}].");
60		}
61
62		if (isset($this->customCreators[$config['driver']])) {
63		return $this->callCustomCreator($config);
64		}
65		$driverMethod = 'create'.ucfirst($config['driver']).'Driver';
66		if (method_exists($this, $driverMethod)) {
67		return $this->{$driverMethod}($config);
68		} else {
69		throw new InvalidArgumentException("Driver [{$config['driver']}] is not supported.");
70		}
71		}
72
73		/**
74		* Get the filesystem connection configuration.
75		*
76		* @param string $name
77		* @return array
78		*/
79		protected function getConfig($name)
80		{
81		if (!function_exists('config')) {
82		return null;
83		}
84		$config = config();
85		$configName = "filesystems.disks.{$name}";
86		if (!$config->has($configName)) {
87		return null;
88		}
89
90		return $config->get($configName)->toArray();
91		}
92
93		/**
94		* Call a custom driver creator.
95		*
96		* @param array $config
97		* @return FileDisk
98		*/
99		protected function callCustomCreator(array $config)
100		{
101		$driver = $this->customCreators[$config['driver']]($this->app, $config);
102		if ($driver instanceof FilesystemInterface) {
103		return $this->adapt($driver);
104		}
105
106		return $driver;
107		}
108
109		/**
110		* Adapt the filesystem implementation.
111		*
112		* @param \League\Flysystem\FilesystemInterface $filesystem
113		* @return \League\Flysystem\FilesystemInterface\|FileDisk
114		*/
115	2	protected function adapt(FilesystemInterface $filesystem)
116		{
117	2	return $filesystem;
118		// return new FlysystemAdapter($filesystem);
119		}
120
121		/**
122		* Create an instance of the local driver.
123		*
124		* @param array $config
125		* @return \League\Flysystem\FilesystemInterface
126		*/
127	2	public function createLocalDriver($config)
128		{
129	2	$permissions = isset($config['permissions']) ? $config['permissions'] : [];
130	2	$links = [];
131		// $links = Arr::get($config, 'links') === 'skip'
132		// ? LocalAdapter::SKIP_LINKS
133		// : LocalAdapter::DISALLOW_LINKS;
134
135	2	return $this->adapt(
136	2	$this->createDisk(
137	2	new LocalAdapter(
138	2	$config['root'],
139	2	LOCK_EX,
140	2	$links,
		0 ignored issues – show Documentation introduced 2019-07-15 09:19 UTC by Report Bug Copy Issue Report `$links` is of type `array`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
141	2	$permissions
142		),
143	2	$config
144		)
145		);
146		}
147
148		/**
149		* Create a Flysystem instance with the given adapter.
150		*
151		* @param \League\Flysystem\AdapterInterface $adapter
152		* @param array $config
153		* @return FileDisk
154		*/
155	2	protected function createDisk(AdapterInterface $adapter, $config)
156		{
157		// $config = Arr::only($config, ['visibility', 'disable_asserts', 'url']);
158
159	2	$this->checkForCacheNeeded($adapter, $config);
160
161	2	return new FileDisk($adapter, count($config) > 0 ? $config : null);
162		}
163
164
165		/**
166		* Set the given disk instance.
167		*
168		* @param string $name
169		* @param FileDisk $disk
170		* @return void
171		*/
172		public function set($name, $disk)
173		{
174		$this->disks[$name] = $disk;
175		}
176
177		/**
178		* Get the default cloud driver name.
179		*
180		* @return string
181		*/
182		public function getDefaultCloudDriver()
183		{
184		return config('filesystems.cloud');
185		}
186		}
187

bytic / filesystem

Push — master ( dee4cd...d18a68 )

FilesystemManager::createLocalDriver() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like