Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class Nip_File extends Nip_Object |
||
|
|||
8 | { |
||
9 | protected $_path; |
||
10 | protected $_name; |
||
11 | protected $_extension; |
||
12 | |||
13 | public function __construct($path = false) |
||
14 | { |
||
15 | if ($path) { |
||
16 | $this->setPath($path); |
||
17 | } |
||
18 | } |
||
19 | |||
20 | public function move($target) |
||
21 | { |
||
22 | $dir = dirname($target); |
||
23 | if (!is_dir($target)) { |
||
24 | mkdir($dir, 0755, true); |
||
25 | } |
||
26 | |||
27 | if (rename($this->getPath(), $target)) { |
||
28 | $this->setPath($target); |
||
29 | } else { |
||
30 | throw new Nip_File_Exception("Cannot move $this->_path file to $target"); |
||
31 | } |
||
32 | |||
33 | return $this; |
||
34 | } |
||
35 | |||
36 | public function copy($target) |
||
37 | { |
||
38 | $dir = dirname($target); |
||
39 | if (!is_dir($target)) { |
||
40 | mkdir($dir, 0755, true); |
||
41 | } |
||
42 | |||
43 | if (copy($this->getPath(), $target)) { |
||
44 | $this->setPath($target); |
||
45 | } else { |
||
46 | throw new Nip_File_Exception("Cannot copy $this->_path file to $target"); |
||
47 | } |
||
48 | |||
49 | return $this; |
||
50 | } |
||
51 | |||
52 | /** |
||
53 | * @param string $target |
||
54 | * |
||
55 | * @return Nip_Process |
||
56 | */ |
||
57 | public function unzip($target) |
||
58 | { |
||
59 | if (!is_dir($target)) { |
||
60 | mkdir($target, 0755, true); |
||
61 | } |
||
62 | |||
63 | $process = new Nip_Process("unzip {$this->_path} -d $target"); |
||
64 | $process->run(); |
||
65 | |||
66 | return $process; |
||
67 | } |
||
68 | |||
69 | public function download($filename = false, $contentType = false) |
||
70 | { |
||
71 | if (!$filename) { |
||
72 | $filename = $this->getName(); |
||
73 | } |
||
74 | if (!$contentType) { |
||
75 | $contentType = 'application/force-download'; |
||
76 | } |
||
77 | |||
78 | header('Pragma: public'); |
||
79 | header('Expires: 0'); |
||
80 | header('Cache-Control: must-revalidate, post-check=0, pre-check=0'); |
||
81 | header('Cache-Control: private', false); |
||
82 | header("Content-Type: $contentType"); |
||
83 | header("Content-Disposition: attachment; filename=\"$filename\""); |
||
84 | header("Content-Length: {$this->getSize()}"); |
||
85 | header('Content-Transfer-Encoding: binary'); |
||
86 | |||
87 | readfile($this->getPath()); |
||
88 | exit(); |
||
89 | } |
||
90 | |||
91 | public function delete() |
||
92 | { |
||
93 | unlink($this->getPath()); |
||
94 | } |
||
95 | |||
96 | public function setPath($path) |
||
103 | } |
||
104 | |||
105 | public function getName() |
||
106 | { |
||
107 | return $this->_name; |
||
108 | } |
||
109 | |||
110 | public function getExtension() |
||
113 | } |
||
114 | |||
115 | public function getSize() |
||
118 | } |
||
119 | |||
120 | public function getTime() |
||
121 | { |
||
122 | return filemtime($this->getPath()); |
||
123 | } |
||
124 | |||
125 | public function getPath() |
||
126 | { |
||
127 | return $this->_path; |
||
128 | } |
||
129 | |||
130 | public function getMimeType() |
||
143 | } |
||
144 | } |
||
145 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"]
, you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths