bytic / document-generator

src/PdfLetters/PdfHelper.php

<?php

namespace ByTIC\DocumentGenerator\PdfLetters;

use setasign\Fpdi\Tcpdf\Fpdi;

/**
 * Class PdfHelper
 * @package ByTIC\DocumentGenerator\PdfLetters
 */
class PdfHelper
{
    /**
     * @param Fpdi $pdf
     * @param $value
     * @param $x
     * @param null $align

Are you sure the doc-type for parameter $align is correct as it would always require null to be passed?

     * @return int|string
     */
    public static function pdfXPosition($pdf, $value, $x, $align = null)
    {
        switch ($align) {
            case 'center':
                return $x - ($pdf->GetStringWidth($value) / 2);
            case 'right':
                $x = $x - $pdf->GetStringWidth($value);
                if ($x < 0) {
                    $x = 0;
                }
                return $x;
            case 'left':
            default:
                return $x;
        }
    }

    /**
     * @param Fpdi $pdf
     * @param $value
     * @param $y
     * @return int|string
     */
    public static function pdfYPosition($pdf, $value, $y)

The parameter $value is not used and could be removed.

    {
        $page = 1;
        if ($y > 297) {
            $page = round($y / 297, 0);
            $y -= ($page * 297);
            $page++;
        }

        if ($pdf->getPage() != $page && $page <= $pdf->getNumPages()) {
            $pdf->setPage($page);

It seems like $page can also be of type double; however, parameter $pnum of TCPDF::setPage() does only seem to accept integer, maybe add an additional type check?

        }

        return $y;
    }

    /**
     * @param Fpdi $pdf
     * @param array $colors
     * @param bool $ret
     * @return string
     */
    public static function pdfPrepareColor($pdf, $colors = [], $ret = false)
    {
        if (is_array($colors) && count($colors) >= 3) {
            return $pdf->SetTextColorArray($colors, $ret);
        }
        return $pdf->SetTextColor(0, 0, 0, $ret);

$ret of type boolean is incompatible with the type double expected by parameter $col4 of TCPDF::setTextColor().

    }
}