ByTIC\DocumentGenerator\PdfLetters\Models\Downloads\DownloadTrait

Complexity

Total Complexity

1

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	populateFromLetter()	0	3	1

<?php

namespace ByTIC\DocumentGenerator\PdfLetters\Models\Downloads;

use ByTIC\DocumentGenerator\PdfLetters\Models\PdfLetters\PdfLetterTrait;
use Nip\Records\Record;

/**
 * Class DownloadTrait
 * @package ByTIC\DocumentGenerator\PdfLetters\Models\Downloads
 *
 * @property string $datetime
 */
trait DownloadTrait
{

    /**
     * @param Record|PdfLetterTrait $letter
     */
    public function populateFromLetter($letter)
    {
        $this->id_letter = $letter->getPrimaryKey();

The property id_letter does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

It seems like getPrimaryKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param Record $recipient
     * @return void
     */
    abstract public function populateFromRecipient($recipient);
}