ByTIC\DocumentGenerator\PdfLetters\Controllers\Admin\Fields\PdfLetterFieldsControllerTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	addNewModel()	0	14	2
A	parseRequestPdfLetterField()	0	13	2

<?php

namespace ByTIC\DocumentGenerator\PdfLetters\Controllers\Admin\Fields;

use ByTIC\DocumentGenerator\PdfLetters\Models\PdfLetters\PdfLetterTrait;
use Nip\Controllers\Traits\AbstractControllerTrait;
use Nip\Records\AbstractModels\Record;

/**
 * Trait PdfLetterFieldsControllerTrait
 * @package ByTIC\DocumentGenerator\PdfLetters
 */
trait PdfLetterFieldsControllerTrait
{
    use AbstractControllerTrait;

    /**
     * @var PdfLetterTrait
     */
    protected $pdfLetter;

    /**
     * @var Record
     */
    protected $parent;

    /**
     * @return PdfLetterTrait
     */
    public function addNewModel()
    {
        /** @var PdfLetterTrait $item */
        $item = $this->getModelManager()->getNew();

It seems like getModelManager() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($this->pdfLetter) {
            $item->populateFromLetter($this->pdfLetter);

It seems like populateFromLetter() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->getView()->Breadcrumbs()->addItem(
                $this->getModelManager()->getLetterManager()->getLabel('add'),
                '#'
            );
            return $item;
        }

        return $this->forward('index', 'error');

It seems like forward() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Called before action
     */
    protected function parseRequestPdfLetterField()
    {
        if ($this->getRequest()->get('id_letter')) {
            $this->pdfLetter = $this->checkForeignModelFromRequest(
                $this->getModelManager()->getLetterManager()->getTable(),
                'id_letter'

'id_letter' of type string is incompatible with the type boolean expected by parameter $key of ByTIC\DocumentGenerator\PdfLetters\Controllers\Admin\Fields\PdfLetterFieldsControllerTrait::checkForeignModelFromRequest().

            );
        } else {
            $field = $this->getModelFromRequest();
            $this->pdfLetter = $field->getPdfLetter();

It seems like $field->getPdfLetter() can also be of type Nip\Helpers\AbstractHelper. However, the property $pdfLetter is declared as type ByTIC\DocumentGenerator\PdfLetters\Models\PdfLetters\PdfLetterTrait. Maybe add an additional type check?

        }

        $this->parent = $this->pdfLetter->getItem();

The method getItem() does not exist on null.

The method getItem() does not exist on Nip\Helpers\AbstractHelper. It seems like you code against a sub-type of Nip\Helpers\AbstractHelper such as Nip_Helper_Url or Nip\Helpers\View\Stylesheets or Nip\Helpers\View\Strings or Nip\Helpers\View\Paginator or Nip\Helpers\View\Arrays or Nip\Helpers\View\Icontext or Nip\Helpers\View\Color or Nip\Helpers\View\Scripts or Nip\Helpers\View\Url.

    }

    /**
     * @param bool $key
     * @return FieldTrait|Record

The type ByTIC\DocumentGenerator\PdfLetters\Controllers\Admin\Fields\FieldTrait was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    abstract protected function getModelFromRequest($key = false);

    /**
     * @param $name
     * @param bool $key
     * @return mixed
     */
    abstract protected function checkForeignModelFromRequest($name, $key = false);
}