ByTIC\DocumentGenerator\PdfLetters\Actions\DownloadStatsProcess

Complexity

Total Complexity

10

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	2
A	getLastLettersFromDownloads()	0	13	1
A	handle()	0	5	3
A	processForManager()	0	14	4

<?php

namespace ByTIC\DocumentGenerator\PdfLetters\Actions;

use ByTIC\DocumentGenerator\PdfLetters\Models\Downloads\DownloadsTrait;
use ByTIC\DocumentGenerator\PdfLetters\Models\PdfLetters\PdfLettersTrait;
use ByTIC\DocumentGenerator\PdfLetters\PdfLettersManager;
use Nip\MailModule\Models\EmailsTable\EmailsTrait;

The type Nip\MailModule\Models\EmailsTable\EmailsTrait was not found. Maybe you did not declare it correctly or list all dependencies?

use Nip\Records\AbstractModels\RecordManager;
use Nip\Records\Locator\ModelLocator;

/**
 * Class DownloadStatsProcess
 * @package ByTIC\DocumentGenerator\PdfLetters\Actions
 */
class DownloadStatsProcess
{

    /**
     * @var PdfLettersManager[]
     */
    protected $managers = [];

    /**
     * DownloadStatsProcess constructor.
     * @param array $managers
     */
    public function __construct(array $managers = null)
    {
        $this->managers = is_array($managers) ? $managers : app('dg.pdf-letters.manager')->getManagerClasses();
    }

    public function handle()
    {
        foreach ($this->managers as $manager) {
            $manager = is_object($manager) ? $manager : ModelLocator::get($manager);
            $this->processForManager($manager);

It seems like $manager can also be of type ByTIC\DocumentGenerator\PdfLetters\PdfLettersManager; however, parameter $letterManager of ByTIC\DocumentGenerator\PdfLetters\Actions\DownloadStatsProcess::processForManager() does only seem to accept Nip\Records\AbstractModels\RecordManager, maybe add an additional type check?

        }
    }

    /**
     * @param RecordManager|PdfLettersTrait $letterManager
     */
    protected function processForManager(RecordManager $letterManager)
    {
        if (!$letterManager->hasRelation('Downloads')) {
            return;
        }
        $downloadsManager = $letterManager->getDownloadsManager();
        $letters = $this->getLastLettersFromDownloads($letterManager, $downloadsManager);

It seems like $downloadsManager can also be of type true; however, parameter $downloadsManager of ByTIC\DocumentGenerator\PdfLetters\Actions\DownloadStatsProcess::getLastLettersFromDownloads() does only seem to accept ByTIC\DocumentGenerator\PdfLetters\Models\Downloads\DownloadsTrait|Nip\Records\AbstractModels\RecordManager, maybe add an additional type check?

        $statsManager = $letterManager->getStatsManager();
        foreach ($letters as $letter) {
            if ($downloadsManager->shouldTrackLetter($letter)) {

The method shouldTrackLetter() does not exist on Nip\Records\Collections\Collection.

                continue;
            }
            $statsManager->compileForLetter($letter);

The method compileForLetter() does not exist on Nip\Records\Collections\Collection.

        }
    }

    /**
     * @param PdfLettersTrait|RecordManager $letterManager
     * @param DownloadsTrait|RecordManager $downloadsManager
     */
    protected function getLastLettersFromDownloads($letterManager, $downloadsManager)
    {
        $letterPK = $letterManager->getRelation('Downloads')->getFK();

It seems like getFK() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like getRelation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The method getFK() does not exist on Nip\Records\Collections\Collection. Did you maybe mean get()?

        $queryDownloads = $downloadsManager->newSelectQuery();

It seems like newSelectQuery() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $queryDownloads->setCols($letterPK);
        $queryDownloads->group($letterPK);
        $queryDownloads->limit(10);

        $queryLetters = $letterManager->newSelectQuery();
        $queryLetters->where('id IN ?', $queryDownloads);

$queryDownloads of type Nip\Database\Query\Select is incompatible with the type array expected by parameter $values of Nip\Database\Query\AbstractQuery::where().

        return $letterManager->findByQuery($queryLetters);

The method findByQuery() does not exist on ByTIC\DocumentGenerator\PdfLetters\Models\PdfLetters\PdfLettersTrait. Did you maybe mean findOneByQuery()?

    }
}