AdminPdfLetterFieldsFormTrait - Code Metrics - Inspection of "Merge branch '0.9' into develop" - bytic/document-generator - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 50ebf9...195aca )

by Gabriel

created 2020-04-28 19:03 UTC

AdminPdfLetterFieldsFormTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	0
dl	0
loc	38
ccs	0
cts	23
cp	0
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	initGenericElements()	7	1
A	initPositionElements()	5	1
A	initColorElement()	4	1
A	initSizeElement()	7	2
A	initAlignElement()	7	2

<?php

namespace ByTIC\DocumentGenerator\PdfLetters\Forms\Fields;

/**
 * Trait AdminPdfLetterFieldsControllerTrait
 * @package ByTIC\DocumentGenerator\PdfLetters\Forms\Fields
 */
trait AdminPdfLetterFieldsFormTrait
{

    protected function initGenericElements()
    {
        $this->initPositionElements();
        $this->initSizeElement();
        $this->initColorElement();
        $this->initAlignElement();
    }

    protected function initPositionElements()
    {
        $this->addInput('x', 'X', true);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->addInput('y', 'Y', true);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    protected function initColorElement()
    {
        $this->addInput('color', translator()->trans('color'), false);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    protected function initSizeElement()
    {
        $this->addSelect('size', translator()->trans('size'), true);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        foreach (range(9, 500) as $size) {
            $this->size->addOption($size, $size);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
    }

    protected function initAlignElement()
    {
        $this->addSelect('align', translator()->trans('align'), true);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        foreach (['left', 'center', 'right'] as $option) {
            $this->getElement('align')->addOption($option, translator()->trans($option));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }
}


1			<?php
2
3			namespace ByTIC\DocumentGenerator\PdfLetters\Forms\Fields;
4
5			/**
6			* Trait AdminPdfLetterFieldsControllerTrait
7			* @package ByTIC\DocumentGenerator\PdfLetters\Forms\Fields
8			*/
9			trait AdminPdfLetterFieldsFormTrait
10			{
11
12			protected function initGenericElements()
13			{
14			$this->initPositionElements();
15			$this->initSizeElement();
16			$this->initColorElement();
17			$this->initAlignElement();
18			}
19
20			protected function initPositionElements()
21			{
22			$this->addInput('x', 'X', true);
			0 ignored issues – show Bug introduced 2020-04-28 19:15 UTC by Report Bug Copy Issue Report It seems like `addInput()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			$this->addInput('y', 'Y', true);
			0 ignored issues – show Bug introduced 2020-04-28 19:15 UTC by Report Bug Copy Issue Report It seems like `addInput()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			}
25
26			protected function initColorElement()
27			{
28			$this->addInput('color', translator()->trans('color'), false);
			0 ignored issues – show Bug introduced 2020-04-28 19:15 UTC by Report Bug Copy Issue Report It seems like `addInput()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29			}
30
31			protected function initSizeElement()
32			{
33			$this->addSelect('size', translator()->trans('size'), true);
			0 ignored issues – show Bug introduced 2020-04-28 19:15 UTC by Report Bug Copy Issue Report It seems like `addSelect()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			foreach (range(9, 500) as $size) {
35			$this->size->addOption($size, $size);
			0 ignored issues – show Bug introduced 2020-04-28 19:15 UTC by Report Bug Copy Issue Report The property `size` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36			}
37			}
38
39			protected function initAlignElement()
40			{
41			$this->addSelect('align', translator()->trans('align'), true);
			0 ignored issues – show Bug introduced 2020-04-28 19:15 UTC by Report Bug Copy Issue Report It seems like `addSelect()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42			foreach (['left', 'center', 'right'] as $option) {
43			$this->getElement('align')->addOption($option, translator()->trans($option));
			0 ignored issues – show Bug introduced 2020-04-28 19:15 UTC by Report Bug Copy Issue Report It seems like `getElement()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
44			}
45			}
46			}
47

bytic / document-generator

Push — master ( 50ebf9...195aca )

AdminPdfLetterFieldsFormTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like