ByTIC\DocumentGenerator\PdfLetters\Models\Stats\StatsTrait

Complexity

Total Complexity

2

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	8	1
A	compileForLetter()	0	2	1

<?php

namespace ByTIC\DocumentGenerator\PdfLetters\Models\Stats;

use ByTIC\DocumentGenerator\Tests\Fixtures\Models\PdfLetters\PdfLetter;
use Nip\Records\AbstractModels\Record;
use Nip\Records\Traits\AbstractTrait\RecordsTrait as AbstractRecordsTrait;

/**
 * Class StatsTrait
 * @package ByTIC\DocumentGenerator\PdfLetters\Models\Stats
 *
 * @method StatTrait getNew
 */
trait StatsTrait
{
    use AbstractRecordsTrait;

    /**
     * @param PdfLetter|Record $letter
     */
    public function compileForLetter($letter)

The parameter $letter is not used and could be removed.

    {
    }

    /**
     * @param $letter
     * @param $related
     * @param $value
     * @return StatTrait
     */
    public function create($letter, $related, $value)
    {
        $stat = $this->getNew();
        $stat->populateFromLetter($letter);
        $stat->populateFromRelated($related);
        $stat->value = $value;
        $stat->insert();

It seems like insert() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $stat;
    }
}