bytic / dispatcher

tests/src/DispatcherTest.php

<?php
declare(strict_types=1);

namespace Nip\Dispatcher\Tests;

use Nip\Dispatcher\Commands\Command;
use Nip\Dispatcher\Dispatcher;
use Nip\Dispatcher\Exceptions\InvalidCommandException;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * Class DispatcherTest
 * @package Nip\Dispatcher\Tests
 */
class DispatcherTest extends AbstractTest
{
    /**
     * @var Dispatcher
     */
    protected $object;


    public function testEmptyCommand()
    {
        $command = new Command();

        self::expectException(InvalidCommandException::class);

The method PHPUnit\Framework\TestCase::expectException() is not static, but was called statically.

        $this->object->dispatchCommand($command);
    }

    public function testClosure()
    {
        $command = new Command();
        $command->setAutoInitRequest(true);
        $command->getRequest(true)->query->set('variable', 'value');
        $command->setAction(
            function (RequestInterface $request, ResponseInterface $response) {
                $response->setContent($request->query->get('variable'));

Accessing query on the interface Psr\Http\Message\RequestInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

The method setContent() does not exist on Psr\Http\Message\ResponseInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Nyholm\Psr7\Response. Are you sure you never get one of those?

                return $response;
            }
        );

        $response = $this->object->dispatchCommand($command)->getReturn();

Are you sure the assignment to $response is correct as $this->object->dispatchCommand($command)->getReturn() targeting Nip\Dispatcher\Commands\Command::getReturn() seems to always return null.

        self::assertInstanceOf(ResponseInterface::class, $response);
        self::assertSame('value', $response->getContent());
    }

    public function testRequestModuleController()
    {
        $command = new Command();
        $command->setAutoInitRequest(true);
        $command->getRequest(true)
            ->setModuleName('frontend')
            ->setControllerName('baseTrait');

        $response = $this->object->dispatchCommand($command)->getReturn();

Are you sure the assignment to $response is correct as $this->object->dispatchCommand($command)->getReturn() targeting Nip\Dispatcher\Commands\Command::getReturn() seems to always return null.

        self::assertInstanceOf(ResponseInterface::class, $response);
        self::assertEquals('index response', $response->getContent());
    }

    protected function setUp(): void
    {
        parent::setUp();
        $this->object = new Dispatcher();
    }
}