bytic / dispatcher

tests/src/Commands/CommandTest.php

<?php

namespace Nip\Dispatcher\Tests\Commands;

use Nip\Dispatcher\Commands\Command;
use Nip\Dispatcher\Tests\AbstractTest;
use Nip\Http\Response\Response;
use Nip\Request;

/**
 * Class CommandTest
 * @package Nip\Dispatcher\Tests\Commands
 */
class CommandTest extends AbstractTest
{
    public function testGetSetRequest()
    {
        $command = new Command();
        self::assertEquals(null, $command->getRequest());
        self::assertFalse($command->hasRequest());

        $request = new Request();

The class Nip\Request has been deprecated: use \Nip\Http\Request

        $command->setRequest($request);

        self::assertTrue($command->hasRequest());
        self::assertEquals($request, $command->getRequest());
    }

    public function testGetSetResponse()
    {
        $command = new Command();
        self::assertEquals(null, $command->getReturn());

Are you sure the usage of $command->getReturn() targeting Nip\Dispatcher\Commands\Command::getReturn() seems to always return null.

        self::assertFalse($command->hasReturn());

        $response = new Response();
        $command->setReturn($response);
        self::assertTrue($command->hasReturn());
        self::assertEquals($response, $command->getReturn());

Are you sure the usage of $command->getReturn() targeting Nip\Dispatcher\Commands\Command::getReturn() seems to always return null.

    }

    /**
     * @throws \Exception
     */
    public function testActionGetParamWithActionStringSet()
    {
        $command = new Command();
        $command->setAction('Module@Controller::action');
        self::assertEquals('Module@Controller::action', $command->getAction());

        self::expectException(\Exception::class);

The method PHPUnit\Framework\TestCase::expectException() is not static, but was called statically.

        $command->getActionParam('name');
    }

    /**
     * @throws \Exception
     */
    public function testActionGetParamWithActionEmpty()
    {
        $command = new Command();

        self::assertNull($command->getActionParam('name'));
    }

    /**
     * @throws \Exception
     */
    public function testActionSetParamWithActionStringSet()
    {
        $command = new Command();
        $command->setAction('Module@Controller::action');

        self::expectException(\Exception::class);

The method PHPUnit\Framework\TestCase::expectException() is not static, but was called statically.

        $command->setActionParam('name', 'value');
    }

    /**
     * @throws \Exception
     */
    public function testActionSetParamWithActionEmpty()
    {
        $command = new Command();

        self::assertNull($command->getActionParam('name'));

        $command->setActionParam('name', 'value');
        self::assertEquals('value', $command->getActionParam('name'));
        self::assertEquals(['name' => 'value'], $command->getAction());
    }
}