Issues in DispatcherAwareTrait.php (master) - Issues in master - bytic/dispatcher - Measure and Improve Code Quality continuously with Scrutinizer

Issues (39)

src/DispatcherAwareTrait.php (1 issue)

Labels

Severity

Minor 1

<?php

namespace Nip\Dispatcher;

use Nip\Http\Response\Response;
use Nip\Request;

/**
 * Trait DispatcherAwareTrait
 * @package Nip\Dispatcher
 */
trait DispatcherAwareTrait
{
    /**
     * @var Dispatcher|null
     */
    protected $dispatcher = null;

    /**
     * @param Request|null $request
     *
     * @return Response|null
     */
    public function dispatchRequest(Request $request = null)
    {
        return $this->getDispatcher()->dispatch($request);
    }

    /**
     * @return Dispatcher
     */
    public function getDispatcher()
    {
        if (!$this->dispatcher) {
            $this->initDispatcher();
        }

        return $this->dispatcher;
    }

    /**
     * @param bool|Dispatcher $dispatcher
     *
     * @return $this
     */
    public function setDispatcher($dispatcher = false)
    {
        $this->dispatcher = $dispatcher;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        return $this;
    }

    protected function initDispatcher()
    {
        $this->setDispatcher($this->newDispatcher());
    }

    /**
     * @return Dispatcher
     */
    protected function newDispatcher()
    {
        return app()->get('dispatcher');
    }
}


1			<?php
2
3			namespace Nip\Dispatcher;
4
5			use Nip\Http\Response\Response;
6			use Nip\Request;
7
8			/**
9			* Trait DispatcherAwareTrait
10			* @package Nip\Dispatcher
11			*/
12			trait DispatcherAwareTrait
13			{
14			/**
15			* @var Dispatcher\|null
16			*/
17			protected $dispatcher = null;
18
19			/**
20			* @param Request\|null $request
21			*
22			* @return Response\|null
23			*/
24			public function dispatchRequest(Request $request = null)
25			{
26			return $this->getDispatcher()->dispatch($request);
27			}
28
29			/**
30			* @return Dispatcher
31			*/
32			public function getDispatcher()
33			{
34			if (!$this->dispatcher) {
35			$this->initDispatcher();
36			}
37
38			return $this->dispatcher;
39			}
40
41			/**
42			* @param bool\|Dispatcher $dispatcher
43			*
44			* @return $this
45			*/
46			public function setDispatcher($dispatcher = false)
47			{
48			$this->dispatcher = $dispatcher;
			0 ignored issues – show Documentation Bug introduced 2020-05-17 17:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$dispatcher` can also be of type `boolean`. However, the property `$dispatcher` is declared as type `Nip\Dispatcher\Dispatcher\|null`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
49
50			return $this;
51			}
52
53			protected function initDispatcher()
54			{
55			$this->setDispatcher($this->newDispatcher());
56			}
57
58			/**
59			* @return Dispatcher
60			*/
61			protected function newDispatcher()
62			{
63			return app()->get('dispatcher');
64			}
65			}
66

bytic / dispatcher

Issues (39)

src/DispatcherAwareTrait.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like