Nip\Dispatcher\Commands\CommandFactory

Complexity

Total Complexity

3

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	createFromAction()	0	6	1
A	createFromRequest()	0	6	1
A	createFromForwardExecption()	0	5	1

<?php

namespace Nip\Dispatcher\Commands;

use Nip\Dispatcher\Exceptions\ForwardException;
use Psr\Http\Message\ServerRequestInterface;

/**
 * Class CommandFactory
 * @package Nip\Dispatcher\Commands
 */
class CommandFactory
{
    /**
     * @param $action
     * @return Command
     */
    public static function createFromAction($action): Command
    {
        $command = new Command();
        $command->setAction($action);
        return $command;
    }

    /**
     * @param ServerRequestInterface|null $request
     * @return Command
     */
    public static function createFromRequest(ServerRequestInterface $request = null): Command
    {
        $command = new Command();
        $command->setRequest($request);

It seems like $request defined by parameter $request on line 29 can be null; however, Nip\Http\Request\RequestAwareTrait::setRequest() does not accept null, maybe add an additional type check?

        return $command;
    }

    /**
     * @param ForwardException $exception
     * @return Command
     */
    public static function createFromForwardExecption(ForwardException $exception)

The parameter $exception is not used and could be removed.

    {
        $command = new Command();
        return $command;
    }
}