MethodCallStage::hasInstanceAction() - Code Metrics - Inspection of "add callFromRequest to dispatcher" - bytic/dispatcher - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 8fa0e2...251f8c )

by Gabriel

created 2018-07-08 18:40 UTC

MethodCallStage::hasInstanceAction() A

↳ Parent: MethodCallStage

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php

namespace Nip\Dispatcher\Resolver\Pipeline\Stages;

use Nip\Controllers\Controller;
use Nip\Dispatcher\Exceptions\InvalidCommandException;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * Class MethodCallStage
 * @package Nip\Dispatcher\Resolver\Pipeline\Stages
 */
class MethodCallStage extends AbstractStage
{
    /**
     * @return void
     * @throws \Exception
     */
    public function processCommand()

    {
        if (!$this->hasInstanceAction()) {
            throw new InvalidCommandException(
                "No valid instance for callback in dispatcher command " .
                "[" . print_r($this->getCommand(), true) . "]"
            );
        }

        $return = $this->callMethod();
        $this->getCommand()->setReturn($return);
    }

    /**
     * @return ResponseInterface
     * @throws \Exception
     */
    protected function callMethod()
    {
        /** @var Controller $controllerInstance */
        $controllerInstance = $this->getCommand()->getActionParam('instance');
        $controllerInstance->setRequest($this->getCommand()->getRequest());
        $method = $this->getCommand()->getActionParam('action');
        return $controllerInstance->{$method}();
    }

    /**
     * @return bool
     */
    protected function hasInstanceAction()
    {
        return $this->getCommand()->hasActionParam('instance');
    }
}

1		<?php
2
3		namespace Nip\Dispatcher\Resolver\Pipeline\Stages;
4
5		use Nip\Controllers\Controller;
6		use Nip\Dispatcher\Exceptions\InvalidCommandException;
7		use Psr\Http\Message\RequestInterface;
8		use Psr\Http\Message\ResponseInterface;
9
10		/**
11		* Class MethodCallStage
12		* @package Nip\Dispatcher\Resolver\Pipeline\Stages
13		*/
14		class MethodCallStage extends AbstractStage
15		{
16		/**
17		* @return void
18		* @throws \Exception
19		*/
20	View Code Duplication	public function processCommand()
		0 ignored issues – show Duplication introduced 2018-07-08 18:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		{
22		if (!$this->hasInstanceAction()) {
23		throw new InvalidCommandException(
24		"No valid instance for callback in dispatcher command " .
25		"[" . print_r($this->getCommand(), true) . "]"
26		);
27		}
28
29		$return = $this->callMethod();
30		$this->getCommand()->setReturn($return);
31		}
32
33		/**
34		* @return ResponseInterface
35		* @throws \Exception
36		*/
37		protected function callMethod()
38		{
39		/** @var Controller $controllerInstance */
40		$controllerInstance = $this->getCommand()->getActionParam('instance');
41		$controllerInstance->setRequest($this->getCommand()->getRequest());
42		$method = $this->getCommand()->getActionParam('action');
43		return $controllerInstance->{$method}();
44		}
45
46		/**
47		* @return bool
48		*/
49		protected function hasInstanceAction()
50		{
51		return $this->getCommand()->hasActionParam('instance');
52		}
53		}

bytic / dispatcher

Push — master ( 8fa0e2...251f8c )

MethodCallStage::hasInstanceAction() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like