DefinitionCollectionTest::testReplace() - Code Metrics - Inspection of "remove composer .lock" - bytic/dispatcher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 56570e...2c8793 )

by Gabriel

created 2019-02-17 18:45 UTC

DefinitionCollectionTest::testReplace() A

↳ Parent: DefinitionCollectionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Nip\Dispatcher\Tests\Resolver\Cache;

use Nip\Dispatcher\Resolver\Cache\DefinitionsCollection;
use Nip\Dispatcher\Resolver\Cache\FileManager;
use Nip\Dispatcher\Tests\AbstractTest;

/**
 * Class FileManagerTest
 * @package Nip\Dispatcher\Tests\Resolver\Cache
 */
class DefinitionCollectionTest extends AbstractTest
{
    public function testReplace()
    {
        $collection = new DefinitionsCollection([
            'test1' => 'Test1',
            'test2' => 'Test2'
        ]);

        $collection->replace(['test1' => 'Test11', 'test3' => 'Test3']);

        static::assertCount(3, $collection->all());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        self::assertSame('Test11', $collection->get('test1'));
    }
}


1			<?php
2
3			namespace Nip\Dispatcher\Tests\Resolver\Cache;
4
5			use Nip\Dispatcher\Resolver\Cache\DefinitionsCollection;
6			use Nip\Dispatcher\Resolver\Cache\FileManager;
7			use Nip\Dispatcher\Tests\AbstractTest;
8
9			/**
10			* Class FileManagerTest
11			* @package Nip\Dispatcher\Tests\Resolver\Cache
12			*/
13			class DefinitionCollectionTest extends AbstractTest
14			{
15			public function testReplace()
16			{
17			$collection = new DefinitionsCollection([
18			'test1' => 'Test1',
19			'test2' => 'Test2'
20			]);
21
22			$collection->replace(['test1' => 'Test11', 'test3' => 'Test3']);
23
24			static::assertCount(3, $collection->all());
			0 ignored issues – show Documentation introduced 2019-02-17 18:52 UTC by Report Bug Copy Issue Report `$collection->all()` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25			self::assertSame('Test11', $collection->get('test1'));
26			}
27			}
28

bytic / dispatcher

Push — master ( 56570e...2c8793 )

DefinitionCollectionTest::testReplace() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like