Nip\Dispatcher\Commands\Command

Complexity

Total Complexity

6

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Test Coverage

Coverage

83.33%

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setReturn()	0	3	1
A	hasReturn()	0	3	1
A	getString()	0	11	3
A	getReturn()	0	3	1

<?php

namespace Nip\Dispatcher\Commands;

use Nip\Dispatcher\Commands\Traits\HasActionTrait;
//use Nip\Dispatcher\Commands\Traits\HasResponseTrait;
use Nip\Dispatcher\Traits\HasRequestTrait;

/**
 * Class ActionCall
 * @package Nip\Dispatcher\Resolver\Pipeline
 */
class Command
{
    use HasRequestTrait;
    use HasActionTrait;

    protected $return = null;

    /**
     * @return string
     */
    public function getString()
    {
        if ($this->hasAction()) {
            return print_r($this->getAction(), true);

The expression return print_r($this->getAction(), true) also could return the type true which is incompatible with the documented return type string.

        }

        if ($this->hasRequest()) {
            return print_r($this->getRequest()->getMCA(), true);

The expression return print_r($this->getRequest()->getMCA(), true) also could return the type true which is incompatible with the documented return type string.

        }

        return print_r($this, true);

The expression return print_r($this, true) also could return the type true which is incompatible with the documented return type string.

    }

    /**
     * @return bool
     */
    public function hasReturn()
    {
        return $this->return !== null;
    }

    /**
     * @return null
     */
    public function getReturn()
    {
        return $this->return;
    }

    /**
     * @param null $return

Are you sure the doc-type for parameter $return is correct as it would always require null to be passed?

     */
    public function setReturn($return)
    {
        $this->return = $return;
    }
}