Issues in Delete.php (master) - Issues in master - bytic/database - Measure and Improve Code Quality continuously with Scrutinizer

Issues (119)

src/Query/Delete.php (1 issue)

Labels

Severity

Major 1

<?php

namespace Nip\Database\Query;

/**
 * Class Delete
 * @package Nip\Database\Query
 */
class Delete extends AbstractQuery
{
    /**
     * Joins together DELETE, FROM, WHERE, ORDER, and LIMIT parts of SQL query
     * @return string
     */
    public function assemble()
    {
        $query = "DELETE FROM {$this->getManager()->protect($this->getTable())}";

        $query .= $this->assembleWhere();

        $order = $this->parseOrder();
        if (!empty($order)) {
            $query .= " order by {$order}";
        }

        $query .= $this->assembleLimit();

        return $query;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			namespace Nip\Database\Query;
4
5			/**
6			* Class Delete
7			* @package Nip\Database\Query
8			*/
9			class Delete extends AbstractQuery
10			{
11			/**
12			* Joins together DELETE, FROM, WHERE, ORDER, and LIMIT parts of SQL query
13			* @return string
14			*/
15			public function assemble()
16			{
17			$query = "DELETE FROM {$this->getManager()->protect($this->getTable())}";
18
19			$query .= $this->assembleWhere();
20
21			$order = $this->parseOrder();
22			if (!empty($order)) {
23			$query .= " order by {$order}";
24			}
25
26			$query .= $this->assembleLimit();
27
28			return $query;
			0 ignored issues – show Bug Best Practice introduced 2020-11-18 19:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $query` returns the type `string` which is incompatible with the return type mandated by `Nip\Database\Query\AbstractQuery::assemble()` of `null`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
29			}
30			}
31

bytic / database

Issues (119)

src/Query/Delete.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like