bytic / database

src/Query/Condition/Condition.php

<?php

namespace Nip\Database\Query\Condition;

use Nip\Database\Query\AbstractQuery as Query;

/**
 * Class Condition
 * @package Nip\Database\Query\Condition
 */
class Condition
{
    protected $_string;
    protected $_values;
    protected $_query;

    /**
     * @param string $string
     */
    public function __construct($string, $values = [])
    {
        $this->_string = $string;
        $this->_values = $values;
    }

    /**
     * @return string
     */
    public function __toString()
    {
        return $this->getString();
    }

    /**
     * @return string
     */
    public function getString()
    {
        return $this->parseString($this->_string, $this->_values);
    }

    /**
     * Parses $string and replaces all instances of "?" with corresponding $values.
     *
     * @param string $string
     * @param array  $values
     *
     * @return string
     */
    public function parseString($string, $values)
    {
        $positions = [];
        $pos = 0;

The assignment to $pos is dead and can be removed.

        $offset = 0;

        while (($pos = strpos($string, "?", $offset)) !== false) {
            $positions[] = $pos;
            $offset = $pos + 1;
        }

        $count = count($positions);

        if ($count == 1) {
            $values = [$values];
        }

        for ($i = 0; $i < $count; $i++) {
            $value = $values[$i];
            if ($value instanceof Query) {
                $value = $this->parseValueQuery($value);
            } elseif (is_array($value)) {
                foreach ($value as $key => $subvalue) {
                    if (trim($subvalue) != '') {
                        $value[$key] = is_numeric($subvalue) ? $subvalue : $this->getQuery()->getManager()->getAdapter()->quote($subvalue);
                    } else {
                        unset($value[$key]);
                    }
                }
                $value = '(' . implode(', ', $value) . ')';
            } elseif (is_int($value) || is_float($value)) {
            } else {
                $value = $this->getQuery()->getManager()->getAdapter()->quote($values[$i]);
            }
            $string = substr_replace($string, $value, strpos($string, '?'), 1);
        }

        return $string;

The expression return $string also could return the type array which is incompatible with the documented return type string.

    }

    /**
     * @param Query $value
     */
    protected function parseValueQuery($value)
    {
        return "(" . $value->assemble() . ")";

Are you sure the usage of $value->assemble() targeting Nip\Database\Query\AbstractQuery::assemble() seems to always return null.

    }

    /**
     * @return Query
     */
    public function getQuery()
    {
        return $this->_query;
    }

    /**
     * @param Query $query
     * @return $this
     */
    public function setQuery($query)
    {
        $this->_query = $query;

        return $this;
    }

    /**
     * @param Condition $condition
     */
    public function and_($condition)
    {
        return new AndCondition($this, $condition);
    }

    /**
     * @param Condition $condition
     */
    public function or_($condition)
    {
        return new OrCondition($this, $condition);
    }

    public function protectCondition($condition)
    {
        return strpos($condition, ' AND ') || strpos($condition, ' OR ') ? '(' . $condition . ')' : $condition;
    }
}