bytic / database

src/Adapters/MySQLi.php

<?php

namespace Nip\Database\Adapters;

/**
 * Class MySQLi
 * @package Nip\Database\Adapters
 */
class MySQLi extends AbstractAdapter implements AdapterInterface
{
    protected $connection;

    /**
     * Connects to MySQL server
     *
     * @param string|boolean $host
     * @param string|boolean $user
     * @param string|boolean $password
     * @param string|boolean $database
     * @param bool $newLink
     *
     * @return resource
     */
    public function connect($host = false, $user = false, $password = false, $database = false, $newLink = false)
    {
        $this->connection = mysqli_connect($host, $user, $password, $newLink);

It seems like $user can also be of type boolean; however, parameter $username of mysqli_connect() does only seem to accept null|string, maybe add an additional type check?

It seems like $password can also be of type boolean; however, parameter $password of mysqli_connect() does only seem to accept null|string, maybe add an additional type check?

It seems like $host can also be of type boolean; however, parameter $hostname of mysqli_connect() does only seem to accept null|string, maybe add an additional type check?

$newLink of type boolean is incompatible with the type null|string expected by parameter $database of mysqli_connect().

The call to mysqli_connect() has too few arguments starting with port.

        if ($this->connection) {
            if ($this->selectDatabase($database)) {
                return $this->connection;

The expression return $this->connection returns the type mysqli which is incompatible with the documented return type resource.

            } else {
                $message = 'Cannot select database '.$database;
            }
        } else {
            $message = mysqli_error($this->connection);

$this->connection of type null is incompatible with the type mysqli expected by parameter $mysql of mysqli_error().

        }

        if (!$this->connection) {
            trigger_error($message, E_USER_WARNING);

It seems like $message can also be of type null; however, parameter $message of trigger_error() does only seem to accept string, maybe add an additional type check?

        }
    }

    /**
     * @param $database
     * @return bool
     */
    public function selectDatabase($database)
    {
        return mysqli_select_db($this->connection, $database);
    }

    /**
     * @param $sql
     * @return bool|\mysqli_result
     */
    public function query($sql)
    {
        try {
            return mysqli_query($this->connection, $sql);
        } catch (\Exception $e) {
            throw new \Exception($e->getMessage().' for query '.$sql, $e->getCode(), $e);
        }
    }

    /**
     * @return int|string
     */
    public function lastInsertID()
    {
        return mysqli_insert_id($this->connection);
    }

    /**
     * @return int
     */
    public function affectedRows()
    {
        return mysqli_affected_rows($this->connection);

The expression return mysqli_affected_rows($this->connection) also could return the type string which is incompatible with the documented return type integer.

    }

    /**
     * @return string
     */
    public function info()
    {
        return mysqli_info($this->connection);
    }

    /**
     * @param $result
     * @return null|object
     */
    public function fetchObject($result)
    {
        return mysqli_fetch_object($result);
    }

    /**
     * @param $result
     * @param $row
     * @param $field
     * @return mixed
     */
    public function result($result, $row, $field)
    {
        return mysqli_result($result, $row, $field);

The function mysqli_result was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    /**
     * @param $result
     */
    public function freeResults($result)
    {
        return mysqli_free_result($result);

Are you sure the usage of mysqli_free_result($result) is correct as it seems to always return null.

    }

    /**
     * @param $table
     * @return array|false
     */
    public function describeTable($table)
    {
        if (!($this->connection instanceof \mysqli)) {
            return false;
        }

        $return = ['fields' => [], 'indexes' => []];

        $result = $this->execute('DESCRIBE '.$table);
        if (is_bool($result)) {
            return false;
        }
        if (mysqli_num_rows($result)) {
            while ($row = $this->fetchAssoc($result)) {
                $return['fields'][$row['Field']] = [
                    'field' => $row['Field'],
                    'type' => $row['Type'],
                    'nullable' => strtoupper($row['Null']) == 'YES',
                    'primary' => (
                        isset($return['indexes']['PRIMARY']['fields'][0])
                        && $return['indexes']['PRIMARY']['fields'][0] == $row['Field']
                    ),
                    'default' => $row['Default'],
                    'auto_increment' => ($row['Extra'] === 'auto_increment'),
                ];
            }
        }

        $result = $this->execute('SHOW INDEX IN '.$table);
        if (is_bool($result)) {
            return false;
        }
        if (mysqli_num_rows($result)) {
            while ($row = $this->fetchAssoc($result)) {
                if (!isset($return['indexes'][$row['Key_name']])) {
                    $return['indexes'][$row['Key_name']] = [];
                }
                $return['indexes'][$row['Key_name']]['fields'][] = $row['Column_name'];
                $return['indexes'][$row['Key_name']]['unique'] = $row['Non_unique'] == '0';
                $return['indexes'][$row['Key_name']]['fulltext'] = $row['Index_type'] == 'FULLTEXT';
                $return['indexes'][$row['Key_name']]['type'] = $row['Index_type'];
            }
        }

        return $return;
    }

    /**
     * @param $result
     * @return array|null
     */
    public function fetchAssoc($result)
    {
        return mysqli_fetch_assoc($result);
    }

    /**
     * @return array
     */
    public function getTables()
    {
        $return = [];

        $result = $this->execute("SHOW FULL TABLES");
        if ($this->numRows($result)) {
            while ($row = $this->fetchArray($result)) {
                $return[$row[0]] = [
                    "type" => $row[1] == "BASE TABLE" ? "table" : "view",
                ];
            }
        }

        return $return;
    }

    /**
     * @param $result
     * @return int
     */
    public function numRows($result)
    {
        return mysqli_num_rows($result);

The expression return mysqli_num_rows($result) also could return the type string which is incompatible with the documented return type integer.

    }

    /**
     * @param $result
     * @return array|null
     */
    public function fetchArray($result)
    {
        return mysqli_fetch_array($result);
    }

    /**
     * @param $value
     * @return int|string
     */
    public function quote($value)
    {
        $value = $this->cleanData($value);

        return is_numeric($value) ? $value : "'$value'";
    }

    /**
     * @param $data
     * @return string
     */
    public function cleanData($data)
    {
        return mysqli_real_escape_string($this->connection, $data);
    }

    /**
     * @return string
     */
    public function error()
    {
        return mysqli_error($this->connection);
    }

    public function disconnect()
    {
        mysqli_close($this->connection);
    }
}