Insert - Code Metrics - Inspection of "Merge branch '0.9' into develop" - bytic/database - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6456b5...bd1840 )

by Gabriel

created 2020-11-18 19:07 UTC

Insert A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Test Coverage

Coverage

89.13%

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	41
c	2
b	0
f	0
dl	0
loc	111
ccs	41
cts	46
cp	0.8913
rs	10
wmc	20

8 Methods

Rating	Name	Size	Complexity
A	parseOnDuplicate()	17	4
A	onDuplicate()	3	1
A	setCols()	4	1
A	parseValues()	8	3
A	assemble()	8	1
A	setValues()	5	1
A	parseData()	19	6
A	parseCols()	6	3

<?php


namespace Nip\Database\Query;

/**
 * Class Insert
 * @package Nip\Database\Query
 */
class Insert extends AbstractQuery
{
    protected $_cols;

    protected $_values;

    /**
     * @return string
     */
    public function assemble()
    {
        $return = "INSERT INTO " . $this->protect($this->getTable());
        $return .= $this->parseCols();
        $return .= $this->parseValues();
        $return .= $this->parseOnDuplicate();

        return $return;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     * @return string
     */
    public function parseCols()
    {
        if (is_array($this->parts['data'][0])) {
            $this->setCols(array_keys($this->parts['data'][0]));
        }
        return $this->_cols ? ' (' . implode(',', array_map([$this, 'protect'], $this->_cols)) . ')' : '';
    }

    /**
     * @param array|string $cols
     * @return $this
     */
    public function setCols($cols = null)
    {
        $this->_cols = $cols;
        return $this;
    }

    /**
     * @return string|false
     */
    public function parseValues()
    {
        if ($this->_values instanceof AbstractQuery) {
            return ' ' . (string) $this->_values;
        } elseif (is_array($this->parts['data'])) {

            return $this->parseData();
        }
        return false;
    }

    /**
     * Parses INSERT data
     *
     * @return string
     */
    protected function parseData()
    {
        $values = [];
        foreach ($this->parts['data'] as $key => $data) {

            foreach ($data as $value) {
                if (!is_array($value)) {
                    $value = [$value];
                }

                foreach ($value as $insertValue) {
                    $values[$key][] = $this->getManager()->getAdapter()->quote($insertValue);
                }
            }
        }
        foreach ($values as &$value) {
            $value = "(" . implode(", ", $value) . ")";
        }

        return ' VALUES ' . implode(', ', $values);
    }

    /**
     * @return string
     */
    public function parseOnDuplicate()
    {
        if ($this->hasPart('onDuplicate')) {
            $update = $this->getManager()->newUpdate();

            $onDuplicates = $this->getPart('onDuplicate');
            $data = [];
            foreach ($onDuplicates as $onDuplicate) {
                foreach ($onDuplicate as $key => $value) {
                    $data[$key] = $value;
                }
            }
            $update->data($data);

            return " ON DUPLICATE KEY UPDATE {$update->parseUpdate()}";
        }
        return '';
    }

    public function setValues($values)
    {
        $this->_values = $values;

        return $this;
    }

    public function onDuplicate($value)
    {
        $this->addPart('onDuplicate', $value);
    }
}


1		<?php
2
3
4		namespace Nip\Database\Query;
5
6		/**
7		* Class Insert
8		* @package Nip\Database\Query
9		*/
10		class Insert extends AbstractQuery
11		{
12		protected $_cols;
13
14		protected $_values;
15
16		/**
17		* @return string
18		*/
19	2	public function assemble()
20		{
21	2	$return = "INSERT INTO " . $this->protect($this->getTable());
22	2	$return .= $this->parseCols();
23	2	$return .= $this->parseValues();
24	2	$return .= $this->parseOnDuplicate();
25
26	2	return $return;
		0 ignored issues – show Bug Best Practice introduced 2020-11-18 19:17 UTC by Report Bug Copy Issue Report The expression `return $return` returns the type `string` which is incompatible with the return type mandated by `Nip\Database\Query\AbstractQuery::assemble()` of `null`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
27		}
28
29		/**
30		* @return string
31		*/
32	2	public function parseCols()
33		{
34	2	if (is_array($this->parts['data'][0])) {
35	2	$this->setCols(array_keys($this->parts['data'][0]));
36		}
37	2	return $this->_cols ? ' (' . implode(',', array_map([$this, 'protect'], $this->_cols)) . ')' : '';
38		}
39
40		/**
41		* @param array\|string $cols
42		* @return $this
43		*/
44	2	public function setCols($cols = null)
45		{
46	2	$this->_cols = $cols;
47	2	return $this;
48		}
49
50		/**
51		* @return string\|false
52		*/
53	2	public function parseValues()
54		{
55	2	if ($this->_values instanceof AbstractQuery) {
56		return ' ' . (string) $this->_values;
57	2	} elseif (is_array($this->parts['data'])) {
		0 ignored issues – show introduced 2020-11-18 19:17 UTC by Report Bug Copy Issue Report The condition `is_array($this->parts['data'])` is always `false`. Loading history...
58	2	return $this->parseData();
59		}
60		return false;
61		}
62
63		/**
64		* Parses INSERT data
65		*
66		* @return string
67		*/
68	2	protected function parseData()
69		{
70	2	$values = [];
71	2	foreach ($this->parts['data'] as $key => $data) {
		0 ignored issues – show Bug introduced 2020-11-18 19:17 UTC by Report Bug Copy Issue Report The expression `$this->parts['data']` of type `null` is not traversable. Loading history...
72	2	foreach ($data as $value) {
73	2	if (!is_array($value)) {
74	2	$value = [$value];
75		}
76
77	2	foreach ($value as $insertValue) {
78	2	$values[$key][] = $this->getManager()->getAdapter()->quote($insertValue);
79		}
80		}
81		}
82	2	foreach ($values as &$value) {
83	2	$value = "(" . implode(", ", $value) . ")";
84		}
85
86	2	return ' VALUES ' . implode(', ', $values);
87		}
88
89		/**
90		* @return string
91		*/
92	2	public function parseOnDuplicate()
93		{
94	2	if ($this->hasPart('onDuplicate')) {
95	1	$update = $this->getManager()->newUpdate();
96
97	1	$onDuplicates = $this->getPart('onDuplicate');
98	1	$data = [];
99	1	foreach ($onDuplicates as $onDuplicate) {
100	1	foreach ($onDuplicate as $key => $value) {
101	1	$data[$key] = $value;
102		}
103		}
104	1	$update->data($data);
105
106	1	return " ON DUPLICATE KEY UPDATE {$update->parseUpdate()}";
107		}
108	1	return '';
109		}
110
111		public function setValues($values)
112		{
113		$this->_values = $values;
114
115		return $this;
116		}
117
118	1	public function onDuplicate($value)
119		{
120	1	$this->addPart('onDuplicate', $value);
121	1	}
122		}
123

bytic / database

Push — master ( 6456b5...bd1840 )

Insert A

Complexity

Size/Duplication

Test Coverage

Importance

8 Methods

Duplication Side-by-Side

Filter issues like