SelectTest::testJoinTableName() - Code Metrics - Inspection of "add support for subquery in join statements" - bytic/database - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b19bf6...648477 )

by Gabriel

created 2018-08-06 06:57 UTC

SelectTest::testJoinTableName() A

↳ Parent: SelectTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

/** @noinspection SqlResolve */

/** @noinspection SqlNoDataSourceInspection */

namespace Nip\Database\Tests\Query;

use Mockery as m;
use Nip\Database\Connections\Connection;
use Nip\Database\Query\Select;
use Nip\Database\Tests\AbstractTest;

/**
 * Class SelectTest
 * @package Nip\Database\Tests\Query
 */
class SelectTest extends AbstractTest
{
    /**
     * @var \UnitTester
     */
    protected $tester;

    /**
     * @var Connection
     */
    protected $connection;

    /**
     * @var Select
     */
    protected $selectQuery;

    public function testSelectSimple()
    {
        $array = ['id, name as new_name', 'table2.test', 'MAX(pos) as pos'];
        call_user_func_array([$this->selectQuery, 'cols'], $array);
        $this->selectQuery->from('table x')->where('id = 5');


        static::assertEquals(
            'SELECT id, name as new_name, table2.test, MAX(pos) as pos FROM table x WHERE id = 5',
            $this->selectQuery->assemble()
        );
    }

    public function testSimpleSelectDistinct()

    {
        $this->selectQuery->cols('id, name')->options('distinct')->from('table x')->where('id = 5');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        static::assertEquals(
            "SELECT DISTINCT id, name FROM table x WHERE id = 5",
            $this->selectQuery->assemble()
        );
    }

    public function testWhereAndWhere()

    {
        $this->selectQuery->cols('id, name')->from('table x');

        $this->selectQuery->where('id = 5')->where("active = 'yes'");
        static::assertEquals(
            "SELECT id, name FROM table x WHERE id = 5 AND active = 'yes'",
            $this->selectQuery->assemble()
        );
    }

    public function testWhereOrWhere()

    {
        $this->selectQuery->cols('id, name')->from('table x');

        $this->selectQuery->where('id = 5')->orWhere('id = 7');
        static::assertEquals(
            "SELECT id, name FROM table x WHERE id = 5 OR id = 7",
            $this->selectQuery->assemble()
        );
    }

    public function testInitializeCondition()
    {
        $condition = $this->selectQuery->getCondition("lorem ipsum");
        static::assertThat($condition, $this->isInstanceOf("Nip\Database\Query\Condition\Condition"));
    }

    public function testNested()

    {
        $this->selectQuery->from("table1");


        $query = $this->connection->newQuery();
        $query->from("table2");

        $query->where("id != 5");

        $this->selectQuery->where("id NOT IN ?", $query);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        static::assertEquals(
            "SELECT * FROM `table1` WHERE id NOT IN (SELECT * FROM `table2` WHERE id != 5)",
            $this->selectQuery->assemble()
        );
    }

    public function testUnion()

    {
        $this->selectQuery->from("table1");


        $query = $this->connection->newQuery();
        $query->from("table2");


        $union = $this->selectQuery->union($query);

        static::assertEquals("SELECT * FROM `table1` UNION SELECT * FROM `table2`", $union->assemble());
    }

    public function testJoinTableName()

    {
        $this->selectQuery->from("table1");

        $this->selectQuery->join("table2", ['id', 'id_table1']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        static::assertEquals(
            "SELECT * FROM `table1` JOIN `table2` ON `table1`.`id` = `table2`.`id_table1`",
            $this->selectQuery->assemble()
        );
    }

    public function testJoinTableNameWithAlias()

    {
        $this->selectQuery->from("table1");

        $this->selectQuery->join(["table2", "alias"], ['id', 'id_table1']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        static::assertEquals(
            "SELECT * FROM `table1` JOIN `table2` AS `alias` ON `table1`.`id` = `table2`.`id_table1`",
            $this->selectQuery->assemble()
        );
    }

    public function testJoinSubQuery()
    {
        $this->selectQuery->from("table1");


        $query = $this->connection->newQuery();
        $query->from("table2");


        $this->selectQuery->join([$query, "alias"], ['id', 'id_table1']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        static::assertEquals(
            'SELECT * FROM `table1` JOIN (SELECT * FROM `table2`) AS `alias` ON `table1`.`id` = `alias`.`id_table1`',
            $this->selectQuery->assemble()
        );
    }

    public function testHasPart()
    {
        $this->selectQuery->cols('id, name');

        self::assertTrue($this->selectQuery->hasPart('cols'));

        $this->selectQuery->setCols('id, name');

        self::assertTrue($this->selectQuery->hasPart('cols'));

        $this->selectQuery->limit('');
        self::assertFalse($this->selectQuery->hasPart('limit'));

        $this->selectQuery->limit('6');
        self::assertTrue($this->selectQuery->hasPart('limit'));

        self::assertFalse($this->selectQuery->hasPart('where'));
    }

    public function testLimit()
    {
        $this->selectQuery->cols('id, name')->from('table x');

        $this->selectQuery->where('id = 5')->where("active = 'yes'");
        $this->selectQuery->limit(5);

        static::assertEquals(
            "SELECT id, name FROM table x WHERE id = 5 AND active = 'yes' LIMIT 5",
            $this->selectQuery->assemble()
        );

        $this->selectQuery->limit(5, 10);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        static::assertEquals(
            "SELECT id, name FROM table x WHERE id = 5 AND active = 'yes' LIMIT 5,10",
            $this->selectQuery->assemble()
        );
    }

    protected function setUp()

    {
        parent::setUp();
        $this->selectQuery = new Select();

        $adapterMock = m::mock('Nip\Database\Adapters\MySQLi')->shouldDeferMissing();
        $adapterMock->shouldReceive('cleanData')->andReturnUsing(function ($data) {
            return $data;
        });
        $this->connection = new Connection(false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->connection->setAdapter($adapterMock);
        $this->selectQuery->setManager($this->connection);
    }
}


1			<?php
2
3			/** @noinspection SqlResolve */
4
5			/** @noinspection SqlNoDataSourceInspection */
6
7			namespace Nip\Database\Tests\Query;
8
9			use Mockery as m;
10			use Nip\Database\Connections\Connection;
11			use Nip\Database\Query\Select;
12			use Nip\Database\Tests\AbstractTest;
13
14			/**
15			* Class SelectTest
16			* @package Nip\Database\Tests\Query
17			*/
18			class SelectTest extends AbstractTest
19			{
20			/**
21			* @var \UnitTester
22			*/
23			protected $tester;
24
25			/**
26			* @var Connection
27			*/
28			protected $connection;
29
30			/**
31			* @var Select
32			*/
33			protected $selectQuery;
34
35			public function testSelectSimple()
36			{
37			$array = ['id, name as new_name', 'table2.test', 'MAX(pos) as pos'];
38			call_user_func_array([$this->selectQuery, 'cols'], $array);
39			$this->selectQuery->from('table x')->where('id = 5');
			0 ignored issues – show Unused Code introduced 2018-02-02 00:15 UTC by Report Bug Copy Issue Report The call to `Select::from()` has too many arguments starting with `'table x'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...

bytic / database

Push — master ( b19bf6...648477 )

SelectTest::testJoinTableName() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like