bytic / controllers

src/View/ControllerViewHydrator.php

<?php

namespace Nip\Controllers\View;

use Nip\Controllers\Controller;
use Nip\Http\Request;
use Nip\Utility\Container;
use Nip\View\View;

/**
 * Class ControllerViewHydrator
 * @package Nip\Controllers\View
 */
class ControllerViewHydrator
{

    /**
     * @param View $view
     * @param null $controller

Are you sure the doc-type for parameter $controller is correct as it would always require null to be passed?

     * @return mixed
     */
    public static function initContentBlocks($view, $controller = null)
    {
        $action = inflector()->underscore($controller->getAction());

The method getAction() does not exist on null.

        $controller = $controller->getName();

        $view->setBlock('content', $controller . '/' . $action);

        return $view;
    }

    /**
     * @param $view
     * @param null|Controller $controller
     * @return mixed
     */
    public static function initVars($view, $controller = null)
    {
        $request = static::detectRequest($controller);
        if (method_exists($view, 'setRequest')) {
            if ($request instanceof Request) {
                $view->setRequest($request);
            }
        }

        $view->set('controller', $controller->getName());
        $view->set('action', $controller->getAction());

        return $view;
    }

    /**
     * @param $view
     * @param void|Controller $controller
     * @return mixed
     */
    public static function populatePath($view, $controller = null)
    {
        $path = ViewPathDetector::for($controller);
        if (is_dir($path)) {

$path of type boolean is incompatible with the type string expected by parameter $filename of is_dir().

            $view->setBasePath($path);
        }

        if (method_exists($controller, 'registerViewPaths'))
        {
            $controller->registerViewPaths($view);

The method registerViewPaths() does not exist on Nip\Controllers\Controller. Since you implemented __call, consider adding a @method annotation.

        }

        return $view;
    }

    /**
     * @param null|Controller $controller
     * @return array|Request|\Nip\Request|string|null
     */
    protected static function detectRequest($controller = null)
    {
        if ($controller instanceof Controller && $controller->hasRequest()) {
            return $controller->getRequest();
        }
        if (function_exists('request') && Container::container()->has('request')) {
            $request = request();
            if ($request instanceof Request) {
                return $request;
            }
        }
        return null;
    }
}