bytic / controllers

src/Response/ResponseFactory/HasViewResponseTrait.php

<?php

namespace Nip\Controllers\Response\ResponseFactory;

use Nip\Http\Response\Response;
use Nip\View\View;

/**
 * Trait HasViewResponseTrait
 * @package Nip\Controllers\Response\ResponseFactory
 */
trait HasViewResponseTrait
{
    /**
     * @var null|View
     */
    protected $view = null;

    /**
     * Create a new response for a given view.
     *
     * @param string|array $view
     * @param array $data
     * @param int $status
     * @param array $headers
     * @return Response
     */
    public function view($view, $data = [], $status = 200, array $headers = [])
    {
        return $this->make($this->renderView($view, $data), $status, $headers);

It seems like $view can also be of type array; however, parameter $view of Nip\Controllers\Response\ResponseFactory\HasViewResponseTrait::renderView() does only seem to accept string, maybe add an additional type check?

It seems like make() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param string $view
     * @param array $data
     * @return bool|string|null
     */
    protected function renderView($view, $data = [])
    {
        foreach ($data as $key => $value) {
            $this->view->set($key, $value);

The method set() does not exist on null.

        }
        return $this->view->load($view, [], true);
    }

    /**
     * @param View|null $view
     */
    public function setView(?View $view): void
    {
        $this->view = $view;
    }
}