Nip\Controllers\Traits\DispatcherAwareTrait

Complexity

Total Complexity

10

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

40%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	call()	0	19	6
A	callMCA()	0	8	1
A	forward()	0	4	1
A	getDispatcher()	0	8	2

<?php

namespace Nip\Controllers\Traits;

use Nip\Container\Container;
use Nip\Controllers\Controller;
use Nip\Dispatcher\Dispatcher;
use Nip\Request;

/**
 * Trait DispatcherAwareTrait
 * @package Nip\Controllers\Traits
 */
trait DispatcherAwareTrait
{
    /**
     * @return mixed
     * @throws \Exception
     */
    public function call()
    {
        $arguments = func_get_args();
        if (count($arguments) >= 3) {
            return $this->callMCA(...$arguments);

$arguments is of type array, but the function expects a boolean.

        }

        if (count($arguments) == 2 && is_array($arguments[1])) {
            if (is_string($arguments[0])) {
                return $this->{$arguments[0]}(...$arguments[1]);
            }
        }

        if (count($arguments) == 1) {
            return $this->{$arguments[0]}();
        }

        throw new \Exception("Controller call method invoked with invalid parameters");
    }

    /**
     * @param bool $action
     * @param bool $controller
     * @param bool $module
     * @param array $params
     * @return mixed
     */
    protected function callMCA($action = false, $controller = false, $module = false, $params = [])
    {
        /** @var Request $newRequest */
        $newRequest = $this->getRequest()->duplicateWithParams($action, $controller, $module, $params);

It seems like getRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        /** @noinspection PhpUnhandledExceptionInspection */
        return $this->getDispatcher()->callFromRequest($newRequest, $params);

The call to Dispatcher::callFromRequest() has too many arguments starting with $params.

    }

    /**
     * @param bool $action
     * @param bool $controller
     * @param bool $module
     * @param array $params
     */
    protected function forward($action = false, $controller = false, $module = false, $params = [])
    {
        $this->getDispatcher()->forward($action, $controller, $module, $params);
    }

    /**
     * @return Dispatcher
     */
    protected function getDispatcher()
    {
        if (function_exists('app')) {
            return app('dispatcher');
        }

        return Container::getInstance()->get('dispatcher');
    }
}