Nip\Controllers\Traits\HttpsTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	forceSecureRequest()	0	7	3
A	checkSecureRequest()	0	4	2
A	needsSecureRequest()	0	3	1
A	isSecureRequest()	0	5	2

<?php

namespace Nip\Controllers\Traits;

use Nip\Http\Request;

/**
 * Trait HttpsTrait
 * @package Nip\Controllers\Traits
 */
trait HttpsTrait
{
    /**
     * @param Request|null $request
     */
    public function checkSecureRequest(Request $request = null)
    {
        if ($this->needsSecureRequest($request)) {
            $this->forceSecureRequest($request);
        }
    }

    /**
     * @param Request|null $request
     */
    public function forceSecureRequest(Request $request = null)
    {
        $request = $request ? $request : $this->getRequest();

It seems like getRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($this->isSecureRequest($request)) {
            return;
        }
        $this->redirect(str_replace('http://', 'https://', $request->fullUrl()));

It seems like redirect() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param Request $request
     * @return mixed
     */
    public function isSecureRequest(Request $request = null)
    {
        $request = $request ? $request : $this->getRequest();

        return $request->isSecure();
    }

    /**
     * @param Request|null $request
     * @return bool
     */
    protected function needsSecureRequest(Request $request = null)

The parameter $request is not used and could be removed.

    {
        return false;
    }
}