bytic / assets

src/functions/assets.php

<?php

use Nip\Container\Container;

/**
 * @param $entryName
 * @param null $packageName

Are you sure the doc-type for parameter $packageName is correct as it would always require null to be passed?

 * @param null $entrypointName

Are you sure the doc-type for parameter $entrypointName is correct as it would always require null to be passed?

 * @return string
 * @noinspection PhpDocMissingThrowsInspection
 */
function assets_render_scripts_files($entryName, string $packageName = null, string $entrypointName = '_default')
{
    return assets_manager()->renderWebpackScriptTags($entryName, $packageName, $entrypointName);

It seems like $packageName can also be of type string; however, parameter $packageName of ByTIC\Assets\AssetsManager::renderWebpackScriptTags() does only seem to accept null, maybe add an additional type check?

}

/**
 * @param $entryName
 * @param string $packageName
 * @param string $entrypointName
 * @return string
 * @noinspection PhpDocMissingThrowsInspection
 */
function assets_render_link_files($entryName, string $packageName = null, string $entrypointName = '_default')
{
    return assets_manager()->renderWebpackLinkTags($entryName, $packageName, $entrypointName);
}

/**
 * @return \ByTIC\Assets\AssetsManager
 * @throws Exception
 */
function assets_manager()
{
    $container = function_exists('app') ? app() : Container::getInstance();
    if (!$container) {
        /** @noinspection PhpUnhandledExceptionInspection */
        throw new Exception("No container was found for assets_manager function");
    }

    $manager = $container->get('assets.manager');
    if (!$manager) {
        /** @noinspection PhpUnhandledExceptionInspection */
        throw new Exception("No Assets Manager was found in the container");
    }

    return $manager;
}