ByTIC\Assets\AssetsManager\HasTagRenderer

Complexity

Total Complexity

3

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getTagRenderer()	0	3	1
A	renderWebpackLinkTags()	0	7	1
A	renderWebpackScriptTags()	0	7	1

<?php

namespace ByTIC\Assets\AssetsManager;

use Symfony\WebpackEncoreBundle\Asset\TagRenderer;

/**
 * Trait HasTagRenderer
 * @package ByTIC\Assets\AssetsManager
 */
trait HasTagRenderer
{
    protected function getTagRenderer(): TagRenderer
    {
        return $this->getContainer()->get('assets.tag_renderer');

It seems like getContainer() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param string $entryName
     * @param null $packageName

Are you sure the doc-type for parameter $packageName is correct as it would always require null to be passed?

     * @param string $entrypointName
     * @return string
     */
    public function renderWebpackScriptTags(
        string $entryName,
        $packageName = null,
        string $entrypointName = '_default'
    ): string {
        return $this->getTagRenderer()
            ->renderWebpackScriptTags($entryName, $packageName, $entrypointName);
    }

    public function renderWebpackLinkTags(
        string $entryName,
        string $packageName = null,
        string $entrypointName = '_default'
    ): string {
        return $this->getTagRenderer()
            ->renderWebpackLinkTags($entryName, $packageName, $entrypointName);
    }
}