bytic / MediaLibrary

src/Media/Traits/UrlMethodsTrait.php

<?php

namespace ByTIC\MediaLibrary\Media\Traits;

use ByTIC\MediaLibrary\UrlGenerator\UrlGeneratorFactory;
use function Nip\url;

/**
 * Trait UrlMethodsTrait
 * @package ByTIC\MediaLibrary\Media\Traits
 */
trait UrlMethodsTrait
{
    /**
     * Get the full url to a original media file.
     *
     * @param string $conversionName
     *
     * @return string
     */
    public function getFullUrl(string $conversionName = ''): string
    {
        return url()->to($this->getUrl($conversionName));
    }

    /**
     * Get the url to a original media file.
     *
     * @param string $conversionName
     *
     * @return string
     */
    public function getUrl(string $conversionName = '')
    {
        $conversionName = $conversionName ? $conversionName : ($this->hasConversion('default') ? 'default' : '');

It seems like hasConversion() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return UrlGeneratorFactory::createForMedia($this, $conversionName);
    }
}