bytic / MediaLibrary

src/Media/Traits/HasConversionsTrait.php

<?php

namespace ByTIC\MediaLibrary\Media\Traits;

use ByTIC\MediaLibrary\Conversions\ConversionCollection;

/**
 * Trait HasConversionsTrait
 * @package ByTIC\MediaLibrary\Media\Traits
 */
trait HasConversionsTrait
{
    protected $conversions = null;

    protected $conversionNames;

    public function getConversionNames(): array
    {
        if ($this->conversionNames == null) {
            $this->conversionNames = $this->generateConversionNames();
        }
        return $this->conversionNames;
    }

    /**
     * @return array
     */
    protected function generateConversionNames()
    {
        $conversions = $this->getConversions();

        $return = [];
        foreach ($conversions as $conversion) {
            $return[] = $conversion->getName();
        }
        return $return;
    }

    public function getConversions(): ConversionCollection
    {
        if ($this->conversions == null) {
            $this->conversions = $this->generateConversions();
        }
        return $this->conversions;
    }

    /**
     * @param $name
     * @return bool
     */
    public function hasConversion($name)
    {
        $names = is_array($name) ? $name : [$name];
        $conversions = $this->getConversionNames();
        foreach ($names as $name) {

$name is overwriting one of the parameters of this function.

            if (!in_array($name, $conversions)) {
                return false;
            }
        }
        return true;
    }

    /**
     * @return ConversionCollection
     */
    protected function generateConversions()
    {
        $collection = $this->getCollection();

It seems like getCollection() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $model = $this->getModel();

It seems like getModel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($collection && $model) {
            return $model->getMediaConversions()->forCollection($collection->getName());
        }
        return new ConversionCollection();
    }


    public function removeConversions()
    {
        $converstions = $this->getConversionNames();
        $converstions[] = 'full';
        $filesystem = $this->getFile()->getFilesystem();

It seems like getFile() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        foreach ($converstions as $converstion) {
            $path = $this->getPath($converstion);

It seems like getPath() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if ($filesystem->has($path)) {
                $filesystem->delete($path);
            }
        }
    }
}