bytic / MediaLibrary

src/HasMedia/HasMediaTrait.php

<?php

namespace ByTIC\MediaLibrary\HasMedia;

use ByTIC\MediaLibrary\Collections\Collection;
use ByTIC\MediaLibrary\HasMedia\StandardCollections\FilesShortcodes;
use ByTIC\MediaLibrary\HasMedia\StandardCollections\ImageShortcodes;
use ByTIC\MediaLibrary\MediaRepository\HasMediaRepositoryTrait;
use ByTIC\MediaLibrary\MediaRepository\MediaRepository;

/**
 * Trait HasMediaTrait.
 */
trait HasMediaTrait
{
    use HasMediaRepositoryTrait;
    use Traits\AddMediaTrait;
    use Traits\HasMediaFilesystemTrait;
    use Traits\HasMediaConversionsTrait;
    use Traits\HasMediaConstraintsTrait;
    use Traits\HasMediaPropertiesTrait;
    use ImageShortcodes;
    use FilesShortcodes;

    /**
     * Get media collection by its collectionName.
     *
     * @param string         $collectionName
     * @param array|callable $filters
     *
     * @return Collection
     */
    public function getMedia(string $collectionName = 'default', $filters = []): Collection
    {
        return $this->getMediaRepository()->getFilteredCollection($collectionName, $filters);

It seems like $filters can also be of type callable; however, parameter $filter of ByTIC\MediaLibrary\MediaRepository\MediaRepository::getFilteredCollection() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param MediaRepository $mediaRepository
     *
     * @return MediaRepository
     */
    protected function hydrateMediaRepository($mediaRepository)
    {
        $mediaRepository->setRecord($this);

$this of type ByTIC\MediaLibrary\HasMedia\HasMediaTrait is incompatible with the type Nip\Records\Record expected by parameter $record of ByTIC\MediaLibrary\MediaRepository\MediaRepository::setRecord().

        if (method_exists($this, 'registerMediaCollections')) {
            $this->registerMediaCollections($mediaRepository);
        }

        if (method_exists($this, 'hydrateMediaRepositoryCustom')) {
            $this->hydrateMediaRepositoryCustom($mediaRepository);
        }

        return $mediaRepository;
    }
}