ByTIC\MediaLibrary\Collections\Traits\HasFilesystemTrait

Complexity

Total Complexity

9

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Test Coverage

Coverage

85.71%

Importance

Changes	1
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getFilesystem()	0	7	2
A	setFilesystem()	0	3	1
A	getBasePathForMedia()	0	15	3
A	initFilesystem()	0	3	1
A	generateFilesystem()	0	3	1
A	getMediaFilesystemDiskName()	0	3	1

<?php

namespace ByTIC\MediaLibrary\Collections\Traits;

use ByTIC\MediaLibrary\PathGenerator\PathGeneratorFactory;
use Nip\Filesystem\FileDisk;

/**
 * Trait HasFilesystemTrait.
 */
trait HasFilesystemTrait
{
    protected $filesystem;

    /**
     * @return FileDisk
     */
    public function getFilesystem()
    {
        if ($this->filesystem == null) {
            $this->initFilesystem();
        }

        return $this->filesystem;
    }

    /**
     * @param mixed $filesystem
     */
    public function setFilesystem($filesystem)
    {
        $this->filesystem = $filesystem;
    }

    /**
     * @return mixed
     */
    public function getBasePathForMedia()
    {
        $method = 'getBasePathForMedia';
        $manager = $this->getRecord()->getManager();

It seems like getRecord() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $media = $this->newMedia();

It seems like newMedia() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (method_exists($manager, $method)) {
            $path = $manager->$method($media);
            if (!empty($path)) {
                return $path;
            }
        }

        return PathGeneratorFactory::create()::$method($media);
    }

    /**
     * @return string
     */
    public function getMediaFilesystemDiskName()
    {
        return $this->getRecord()->getMediaFilesystemDiskName($this->getName());

It seems like getName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    protected function initFilesystem()
    {
        $this->setFilesystem($this->generateFilesystem());
    }

    /**
     * @return FileDisk
     */
    protected function generateFilesystem()
    {
        return $this->getRecord()->getMediaFilesystemDisk($this->getName());
    }
}