ByTIC\MediaLibrary\Models\MediaProperties\MediaProperties

Complexity

Total Complexity

6

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	for()	0	16	3
A	createFor()	0	7	1
A	generateTable()	0	3	1
A	forCollection()	0	3	1

<?php

namespace ByTIC\MediaLibrary\Models\MediaProperties;

use ByTIC\MediaLibrary\Collections\Collection;
use ByTIC\MediaLibrary\HasMedia\Traits\HasMediaPropertiesTrait;
use Nip\Records\AbstractModels\Record;
use Nip\Records\RecordManager;
use Nip\Records\Traits\Relations\HasRelationsRecordTrait;

/**
 * Class MediaProperties
 * @package ByTIC\MediaLibrary\Models\MediaRecords
 *
 * @method MediaProperty getNew()
 */
class MediaProperties extends RecordManager
{
    /**
     * @param Record|HasMediaPropertiesTrait $model
     * @param Collection|string $collection
     * @return MediaProperty|Record
     */
    public function for(Record $model, $collection)
    {
        $collection = is_object($collection) ? $collection->getName() : $collection;
        if ($model->hasRelation('MediaProperties')) {
            return $model->getRelation('MediaProperties')->getResults()->filter(

The method getResults() does not exist on Nip\Helpers\AbstractHelper. It seems like you code against a sub-type of Nip\Helpers\AbstractHelper such as Nip_Helper_Url or Nip\Helpers\View\Stylesheets or Nip\Helpers\View\Strings or Nip\Helpers\View\Paginator or Nip\Helpers\View\Arrays or Nip\Helpers\View\Icontext or Nip\Helpers\View\Color or Nip\Helpers\View\Scripts or Nip\Helpers\View\Url.

                function ($item) use ($collection) {
                    return $item->collection_name == $collection;
                }
            )->current();
        }

        return $this->findOneByParams([

Are you sure the usage of $this->findOneByParams(array('where' => array(array('model =?', $model->getManager()->getMorphName()), array('model_id =?', $model->getPrimaryKey()), array('collection_name=?', $collection)))) targeting Nip\Records\AbstractModels\RecordManager::findOneByParams() seems to always return null.

            'where' => [
                ['model =?', $model->getManager()->getMorphName()],
                ['model_id =?', $model->getPrimaryKey()],
                ['collection_name=?', $collection]
            ]
        ]);
    }

    /**
     * @param $collection
     * @return MediaProperty|Record
     */
    public function forCollection(Collection $collection)
    {
        return $this->for($collection->getRecord(), $collection->getName());

It seems like $collection->getRecord() can also be of type ByTIC\MediaLibrary\HasMedia\HasMediaTrait; however, parameter $model of ByTIC\MediaLibrary\Models\MediaProperties\MediaProperties::for() does only seem to accept Nip\Records\AbstractModels\Record, maybe add an additional type check?

    }

    /**
     * @param Record|HasMediaPropertiesTrait $model
     * @param $collection
     * @return MediaProperty
     */
    public function createFor(Record $model, $collection)
    {
        $record = $this->getNew();
        $record->populateFromModel($model);
        $record->populateFromCollection($collection);
        $record->insert();
        return $record;
    }

    /**
     * @inheritDoc
     * @noinspection PhpMissingParentCallCommonInspection
     */
    protected function generateTable()
    {
        return 'media-properties';
    }
}